Issue 257763005: Revert 266094 "Add ScopedStubEnterpriseInstallAttributes for tes..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257763005: Revert 266094 "Add ScopedStubEnterpriseInstallAttributes for tes..." (Closed)

Created:
6 years, 8 months ago by Alexander Potapenko

Modified:
6 years, 8 months ago

Reviewers:
Steve Condie

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266094 "Add ScopedStubEnterpriseInstallAttributes for tes..." > Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes. > > This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member. > > BUG=243341 > > Review URL: https://codereview.chromium.org/247283007 TBR=stepco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266179

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -36 lines)			Patch
M	trunk/src/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/stub_enterprise_install_attributes.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

6 years, 8 months ago (2014-04-25 12:54:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r266179 (tree was closed).

Expand Messages | Collapse Messages