Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: mojo/common/values.mojom

Issue 2577563002: Add struct traits for base::Value. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/test_common_custom_types.mojom ('k') | mojo/common/values.typemap » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/values.mojom
diff --git a/mojo/common/values.mojom b/mojo/common/values.mojom
index 822df34a1ed61caa3269164567930fcf13631362..7107b8937bb4feb997235ed8e154b2e33bb8f103 100644
--- a/mojo/common/values.mojom
+++ b/mojo/common/values.mojom
@@ -4,8 +4,28 @@
module mojo.common.mojom;
-[Native]
-struct ListValue;
+union Value {
+ NullValue? null_value;
+ bool bool_value;
+ int32 int_value;
+ double double_value;
+ string string_value;
+ array<uint8> binary_value;
+ DictionaryValue dictionary_value;
+ ListValue list_value;
+};
+
+struct ListValue {
+ array<Value> values;
+};
+
+struct DictionaryValue {
+ map<string, Value> values;
+};
+
+// An empty struct representing a null base::Value.
+struct NullValue {
+};
[Native]
-struct DictionaryValue;
+struct LegacyListValue;
Ken Rockot(use gerrit already) 2016/12/16 16:39:57 Can we add a TODO to remote this ASAP?
Sam McNally 2016/12/18 23:18:31 Done.
« no previous file with comments | « mojo/common/test_common_custom_types.mojom ('k') | mojo/common/values.typemap » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698