Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2577483002: headless: Remove iostream usage (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Remove iostream usage This patch removes usage of the iostream headers in Headless Shell to avoid introducing static initializers to Chrome. BUG=612904 R=altimin@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c3ac4fc0327b6b3001b82fd0c01e3f504997e251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M headless/app/headless_shell.cc View 5 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
altimin
Can I hope for a migration to puts() in 2017? lgtm.
4 years ago (2016-12-13 18:04:44 UTC) #5
Sami
On 2016/12/13 18:04:44, altimin wrote: > Can I hope for a migration to puts() in ...
4 years ago (2016-12-13 18:10:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577483002/1
4 years ago (2016-12-13 18:10:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/324935)
4 years ago (2016-12-13 18:21:00 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3ac4fc0327b6b3001b82fd0c01e3f504997e251 Cr-Commit-Position: refs/heads/master@{#438230}
4 years ago (2016-12-13 18:31:06 UTC) #13
Sami
4 years ago (2016-12-13 18:32:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3ac4fc0327b6b3001b82fd0c01e3f504997e251.

Powered by Google App Engine
This is Rietveld 408576698