Enable writing to logdog for tombstones.py.

build/android/tombstones.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Find the most recent tombstone file(s) on all connected devices
 # and prints their stacks.
 #
 # Assumes tombstone file was created with current symbols.
 
 import argparse
 import datetime
 import logging
 import multiprocessing
 import os
 import re
 import subprocess
 import sys
 
 import devil_chromium
 
 from devil.android import device_blacklist
 from devil.android import device_errors
 from devil.android import device_utils
 from devil.utils import run_tests_helper
 from pylib import constants
 
+sys.path.insert(0, os.path.abspath(os.path.join(
+    constants.DIR_SOURCE_ROOT, 'tools', 'swarming_client')))
+from libs.logdog import bootstrap # pylint: disable=import-error
+
 
 _TZ_UTC = {'TZ': 'UTC'}
 
 
 def _ListTombstones(device):
   """List the tombstone files on the device.
 
   Args:
     device: An instance of DeviceUtils.
 
@@ skipping 184 matching lines @@
     device: An instance of DeviceUtils.
   """
   all_tombstones = list(_ListTombstones(device))
   if not all_tombstones:
     logging.warning('No tombstones to clear.')
 
   for tombstone_file, _ in all_tombstones:
     _EraseTombstone(device, tombstone_file)
 
 def ResolveTombstones(device, resolve_all_tombstones, include_stack_symbols,
-                      wipe_tombstones, jobs=4):
+                      wipe_tombstones, jobs=4, save_to_logdog=False,
+                      stream_name=None):
   """Resolve tombstones in the device.
 
   Args:
     device: An instance of DeviceUtils.
     resolve_all_tombstone: Whether to resolve every tombstone.
     include_stack_symbols: Whether to include symbols for stack data.
     wipe_tombstones: Whether to wipe tombstones.
     jobs: Number of jobs to use when processing multiple crash stacks.
+    save_to_logdog: Whether will save tombstones to logdog.
+    stream_name: The name of the logdog stream that records tombstones.
   """
-  return _ResolveTombstones(jobs,
-                            _GetTombstonesForDevice(device,
-                                                    resolve_all_tombstones,
-                                                    include_stack_symbols,
-                                                    wipe_tombstones))
+  tombstones = _ResolveTombstones(jobs,
+                                  _GetTombstonesForDevice(
+                                      device,
+                                      resolve_all_tombstones,
+                                      include_stack_symbols,
+                                      wipe_tombstones))
+  if not save_to_logdog or not stream_name:
+    return tombstones
+  else:

[jbudorick, 2016/12/14 01:34:04]

This should be handled by a separate function that either takes the resolved
tombstones as a parameter or calls ResolveTombstones to get them, not by a flag
passed to ResolveTombstones. (I think I prefer the first one.)

[BigBossZhiling, 2016/12/14 17:08:21]

Done.

+    try:
+      tombstones_url = ''
+      stream_client = bootstrap.ButlerBootstrap.probe().stream_client()
+      logdog_stream = stream_client.open_text(stream_name)
+      for tombstones_line in tombstones:
+        logdog_stream.write(tombstones_line + '\n')
+      tombstones_url = logdog_stream.get_viewer_url(stream_name)
+      logdog_stream.close()
+    except bootstrap.NotBootstrappedError:
+      logging.exception('Error not bootstrapped. Failed to start logdog')
+    except (KeyError, ValueError) as e:
+      logging.exception('Error when creating stream_client/stream: %s.', e)
+    except Exception as e: # pylint: disable=broad-except
+      logging.exception('Unknown Error: %s.', e)
+    return tombstones_url
 
 def main():
   custom_handler = logging.StreamHandler(sys.stdout)
   custom_handler.setFormatter(run_tests_helper.CustomFormatter())
   logging.getLogger().addHandler(custom_handler)
   logging.getLogger().setLevel(logging.INFO)
 
   parser = argparse.ArgumentParser()
   parser.add_argument('--device',
                       help='The serial number of the device. If not specified '
@@ skipping 37 matching lines @@
   # http://bugs.python.org/issue7980
   for device in devices:
     resolved_tombstones = ResolveTombstones(
         device, args.all_tombstones,
         args.stack, args.wipe_tombstones, args.jobs)
     for line in resolved_tombstones:
       logging.info(line)
 
 if __name__ == '__main__':
   sys.exit(main())