Add print of all system properties after provisioning.

build/android/pylib/android_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 """
 # pylint: disable-all
 
@@ skipping 618 matching lines @@
     # A dict of commands the user should not run directly and a mapping to the
     # API they should use instead.
     preferred_apis = {
         'getprop': 'system_properties[<PROPERTY>]',
         'setprop': 'system_properties[<PROPERTY>]',
         'su': 'RunShellCommandWithSU()',
         }
 
     # A dict of commands to methods that may call them.
     whitelisted_callers = {
         'su': 'RunShellCommandWithSU',

[tonyg, 2014/04/26 00:41:31]

We should be able to add your method name here instead of adding skip_check. Or
else, perhaps we should get rid of whitelisted_callers and have
RunShellCommandWithSU pass skip_check.

[navabi, 2014/04/26 22:52:06]

Done.

         }
 
     base_command = shlex.split(command)[0]
     if (base_command in preferred_apis and
         (base_command not in whitelisted_callers or
          whitelisted_callers[base_command] not in [
           f[3] for f in inspect.stack()])):
       error_msg = ('%s should not be run directly. Instead use: %s' %
                    (base_command, preferred_apis[base_command]))
       raise ValueError(error_msg)
 
   # It is tempting to turn this function into a generator, however this is not
   # possible without using a private (local) adb_shell instance (to ensure no
   # other command interleaves usage of it), which would defeat the main aim of
   # being able to reuse the adb shell instance across commands.
-  def RunShellCommand(self, command, timeout_time=20, log_result=False):
+  def RunShellCommand(self, command, timeout_time=20, log_result=False,
+                      skip_check=False):
     """Send a command to the adb shell and return the result.
 
     Args:
       command: String containing the shell command to send. Must not include
                the single quotes as we use them to escape the whole command.
       timeout_time: Number of seconds to wait for command to respond before
         retrying, used by AdbInterface.SendShellCommand.
       log_result: Boolean to indicate whether we should log the result of the
                   shell command.
 
     Returns:
       list containing the lines of output received from running the command
     """
-    self._CheckCommandIsValid(command)
+    if not skip_check:
+      self._CheckCommandIsValid(command)
     self._LogShell(command)
     if "'" in command:
       logging.warning(command + " contains ' quotes")
     result = self._adb.SendShellCommand(
         "'%s'" % command, timeout_time).splitlines()
     # TODO(b.kelemen): we should really be able to drop the stderr of the
     # command or raise an exception based on what the caller wants.
     result = [ l for l in result if not l.startswith('WARNING') ]
     if ['error: device not found'] == result:
       raise errors.DeviceUnresponsiveError('device not found')
     if log_result:
       self._LogShell('\n'.join(result))
     return result
 
   def GetShellCommandStatusAndOutput(self, command, timeout_time=20,
-                                     log_result=False):
+                                     log_result=False, skip_check=False):
     """See RunShellCommand() above.
 
     Returns:
       The tuple (exit code, list of output lines).
     """
     lines = self.RunShellCommand(
         command + '; echo %$?', timeout_time, log_result)
     last_line = lines[-1]
     status_pos = last_line.rfind('%')
     assert status_pos >= 0
@@ skipping 397 matching lines @@
   _TEMP_FILE_BASE_FMT = 'temp_file_%d'
   _TEMP_SCRIPT_FILE_BASE_FMT = 'temp_script_file_%d.sh'
 
   def _GetDeviceTempFileName(self, base_name):
     i = 0
     while self.FileExistsOnDevice(
         self.GetExternalStorage() + '/' + base_name % i):
       i += 1
     return self.GetExternalStorage() + '/' + base_name % i
 
-  def RunShellCommandWithSU(self, command, timeout_time=20, log_result=False):
-    return self.RunShellCommand('su -c %s' % command, timeout_time, log_result)
+  def RunShellCommandWithSU(self, command, timeout_time=20, log_result=False,
+                            skip_check='False'):
+    return self.RunShellCommand('su -c %s' % command, timeout_time, log_result,
+                                skip_check)
 
   def CanAccessProtectedFileContents(self):
     """Returns True if Get/SetProtectedFileContents would work via "su".
 
     Devices running user builds don't have adb root, but may provide "su" which
     can be used for accessing protected files.
     """
     r = self.RunShellCommandWithSU('cat /dev/null')
     return r == [] or r[0].strip() == ''
 
@@ skipping 809 matching lines @@
   """
   def __init__(self, output):
     self._output = output
 
   def write(self, data):
     data = data.replace('\r\r\n', '\n')
     self._output.write(data)
 
   def flush(self):
     self._output.flush()