Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 257743002: Add print of all system properties after provisioning. (Closed)

Created:
6 years, 8 months ago by navabi
Modified:
6 years, 8 months ago
Reviewers:
tonyg, zty, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add print of all system properties after provisioning. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266433

Patch Set 1 #

Patch Set 2 : Remove extra call to getprop. #

Total comments: 2

Patch Set 3 : Remove skip_check and add to whitelesit. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/android/provision_devices.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 11 (0 generated)
navabi
6 years, 8 months ago (2014-04-25 00:39:07 UTC) #1
zty
lgtm
6 years, 8 months ago (2014-04-25 00:50:48 UTC) #2
navabi
The CQ bit was checked by navabi@google.com
6 years, 8 months ago (2014-04-25 01:44:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/257743002/10001
6 years, 8 months ago (2014-04-25 02:03:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 02:03:29 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-25 02:03:30 UTC) #6
tonyg
https://codereview.chromium.org/257743002/diff/10001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/257743002/diff/10001/build/android/pylib/android_commands.py#newcode639 build/android/pylib/android_commands.py:639: 'su': 'RunShellCommandWithSU', We should be able to add your ...
6 years, 8 months ago (2014-04-26 00:41:30 UTC) #7
navabi
https://codereview.chromium.org/257743002/diff/10001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/257743002/diff/10001/build/android/pylib/android_commands.py#newcode639 build/android/pylib/android_commands.py:639: 'su': 'RunShellCommandWithSU', On 2014/04/26 00:41:31, tonyg wrote: > We ...
6 years, 8 months ago (2014-04-26 22:52:06 UTC) #8
navabi
https://codereview.chromium.org/257743002/diff/30001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/257743002/diff/30001/build/android/pylib/android_commands.py#newcode643 build/android/pylib/android_commands.py:643: base_command = shlex.split(command)[0].strip(';') without this call to strip the ...
6 years, 8 months ago (2014-04-26 22:54:40 UTC) #9
tonyg
lgtm
6 years, 8 months ago (2014-04-27 19:03:57 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 05:54:10 UTC) #11
Message was sent while issue was closed.
Change committed as 266433

Powered by Google App Engine
This is Rietveld 408576698