Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2577423002: Further reduce use of Compiler.closedWorld. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -555 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 2 chunks +55 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/assert_message_throw_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 2 chunks +44 lines, -67 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/closure_tracer_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 1 chunk +18 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/container_mask_equal_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dictionary_types_test.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 3 chunks +73 lines, -65 lines 0 comments Download
M tests/compiler/dart2js/issue13354_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/try_catch_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer2_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/list_tracer3_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/list_tracer_typed_data_length_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_const_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_keys_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/mirror_final_field_inferrer2_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mirror_final_field_inferrer_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/needs_no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_and_or_test.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 2 chunks +19 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure2_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure3_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure4_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure5_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart View 3 chunks +15 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field3_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field_test.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure2_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 1 chunk +76 lines, -82 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 7 chunks +13 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/subtypeset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 5 chunks +52 lines, -44 lines 0 comments Download
M tests/compiler/dart2js/type_inference6_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference7_test.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/type_inference8_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference_switch_test.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test_helper.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/world_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-16 14:55:51 UTC) #2
Johnni Winther
ping
4 years ago (2016-12-19 14:31:27 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-20 01:05:34 UTC) #4
Johnni Winther
4 years ago (2016-12-20 08:44:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bc1b27bc7949fa5ca0f4f66c20d39c112091c7b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698