Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 25774002: HTTP GM baseline viewer: server should serve files from gm/rebaseline_server dir (Closed)

Created:
7 years, 2 months ago by epoger
Modified:
7 years, 1 month ago
Reviewers:
jcgregorio
CC:
skia-review_googlegroups.com, bsalomon
Visibility:
Public.

Description

HTTP GM baseline viewer: server should serve files from gm/rebaseline_server dir (SkipBuildbotRuns) R=jcgregorio@google.com Committed: https://code.google.com/p/skia/source/detail?r=11583

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M gm/rebaseline_server/server.py View 2 chunks +13 lines, -4 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Ready for review. https://codereview.chromium.org/25774002/diff/1/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/25774002/diff/1/gm/rebaseline_server/server.py#newcode164 gm/rebaseline_server/server.py:164: static_dir = os.path.realpath(os.path.join(PARENT_DIRECTORY, 'static')) Main purpose ...
7 years, 2 months ago (2013-10-02 18:39:56 UTC) #1
jcgregorio
LGTM
7 years, 2 months ago (2013-10-02 19:26:28 UTC) #2
epoger
7 years, 2 months ago (2013-10-02 19:27:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698