Refactor ArcBridgeServiceImpl part 2.

components/arc/arc_bridge_service_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_BRIDGE_SERVICE_IMPL_H_
 #define COMPONENTS_ARC_ARC_BRIDGE_SERVICE_IMPL_H_
 
 #include <memory>
-#include <string>
-#include <vector>
 
-#include "base/files/scoped_file.h"
+#include "base/callback.h"
 #include "base/macros.h"
-#include "base/memory/ref_counted.h"
-#include "base/task_runner.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_session_observer.h"
-#include "mojo/public/cpp/bindings/binding.h"
+
+template <typename T>
+class scoped_refptr;
+
+namespace base {
+class TaskRunner;
+}  // namespace base
 
 namespace arc {
 
 class ArcSession;
 
 // Real IPC based ArcBridgeService that is used in production.
 class ArcBridgeServiceImpl : public ArcBridgeService,
                              public ArcSessionObserver {
  public:
   // This is the factory interface to inject ArcSession instance
@@ skipping 15 matching lines @@
 
   // Returns the current ArcSession instance for testing purpose.
   ArcSession* GetArcSessionForTesting() { return arc_session_.get(); }
 
   // Normally, automatic restarting happens after a short delay. When testing,
   // however, we'd like it to happen immediately to avoid adding unnecessary
   // delays.
   void SetRestartDelayForTesting(const base::TimeDelta& restart_delay);
 
  private:
-  // If all pre-requisites are true (ARC is available, it has been enabled, and
-  // the session has started), and ARC is stopped, start ARC. If ARC is running
-  // and the pre-requisites stop being true, stop ARC.
-  void PrerequisitesChanged();
-
   // Starts to run an ARC instance.
   void StartArcSession();
 
   // Stops the running instance.
   void StopInstance();
 
   // ArcSessionObserver:
   void OnSessionReady() override;
   void OnSessionStopped(StopReason reason) override;
 
-  std::unique_ptr<ArcSession> arc_session_;
-
-  // If the user's session has started.
-  bool session_started_;
+  // Whether a client requests to run session or not.
+  bool running_ = false;

[Luis Héctor Chávez, 2016/12/16 23:20:12]

nit: I'd call this |run_requested_|, because it is possible for this to be true
when it is not running, and false when it is.

[hidehiko, 2016/12/19 08:05:11]

Wow, good suggestion. Thank you!

 
   // Instead of immediately trying to restart the container, give it some time
   // to finish tearing down in case it is still in the process of stopping.
   base::TimeDelta restart_delay_;
   base::OneShotTimer restart_timer_;
 
   // Factory to inject a fake ArcSession instance for testing.
   ArcSessionFactory factory_;
 
+  // ArcSession object for currently running ARC instance. This should be
+  // nullptr if the state is STOPPED, otherwise non-nullptr.
+  std::unique_ptr<ArcSession> arc_session_;
+
   // WeakPtrFactory to use callbacks.
-  base::WeakPtrFactory<ArcBridgeServiceImpl> weak_factory_;
+  base::WeakPtrFactory<ArcBridgeServiceImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeServiceImpl);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_BRIDGE_SERVICE_IMPL_H_