third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2577363002: Implement CSS Logical Properties: inline/block size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2577363002: Implement CSS Logical Properties: inline/block size (Closed)

Patch Set: Fix webexposed test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperty.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index a3178b63a3d4268ce3a42b2ce514a918ff86b559..479b045cb31e871ce781762c366969fbb3f6ab22 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -3373,6 +3373,12 @@ const CSSValue* ComputedStyleCSSValueMapping::get(

case CSSPropertyWebkitMinLogicalHeight:

case CSSPropertyWebkitMaxLogicalWidth:

case CSSPropertyWebkitMaxLogicalHeight:

+ case CSSPropertyInlineSize:

cbiesinger 2016/12/16 18:51:49 Please put these in alphabetical order (ie. above

+ case CSSPropertyBlockSize:

+ case CSSPropertyMinInlineSize:

+ case CSSPropertyMinBlockSize:

+ case CSSPropertyMaxInlineSize:

+ case CSSPropertyMaxBlockSize:

ASSERT_NOT_REACHED();

return nullptr;