third_party/WebKit/LayoutTests/css3/logical-props/logicalprops-block-size.html - Issue 2577363002: Implement CSS Logical Properties: inline/block size

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/logical-props/logicalprops-block-size.html

Issue 2577363002: Implement CSS Logical Properties: inline/block size (Closed)

Patch Set: Refactor test case, add {inline-,block-}size overrides width height Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset="utf-8">

	3 <title>CSS Logical Properties: {max-,min-}block-size</title>

	4 <link rel="help" href="https://drafts.csswg.org/css-logical-props/">

	5 <link rel="help" href="https://drafts.csswg.org/css-writing-modes/#logical-to-ph ysical">

	6

	7 <style>

	8 div {

	9 border: 1px solid #000;

	10 }

	11 #div1 {

	12 block-size: 40px;

	13 min-block-size: 50px;

	14 max-block-size: 100px;

	15 }

	16 #div2 {

	17 block-size: 100px;

	18 min-block-size: 50px;

	19 max-block-size: 100px;

	20 }

	21 #div3 {

	22 block-size: 120px;

	23 min-block-size: 50px;

	24 max-block-size: 100px;

	25 }

	26

	27 p {

	28 border: 1px solid #000;

	29 }

	30 #p1 {

	31 block-size: 100px;

	32 height: 50px;

	33 }

	34 #p2 {

	35 height: 50px;

	36 block-size: 100px;

	37 }

	38 </style>

	39

	40 <div id="div1">Hello, this is a test</div>

	41 <div id="div2">Hello, this is a test</div>

	42 <div id="div3">Hello, this is a test</div>
	rune 2016/12/22 13:13:28 I think using testharness.js and check computed wi I think using testharness.js and check computed width and height would be preferred here. Currently there's no clear pass condition without checking the reference.
	43

	44 <p id="p1">Hello, this is a test</div>

	45 <p id="p2">Hello, this is a test</div>

OLD	NEW