Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2577313002: memory coordinator: Resume suspended renderer on NORMAL state change (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 2d6fd854c9b61c5d3f5307310737f119d2068f39..920dad7d4de0fc70fbfcc186fc8b34a6d49dfab7 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -1894,7 +1894,6 @@ void RenderThreadImpl::OnProcessResume() {
// and follow MemoryCoordinator's request.
base::MemoryCoordinatorClientRegistry::GetInstance()->Notify(
base::MemoryState::NORMAL);
- renderer_scheduler_->ResumeRenderer();
}
}
@@ -2261,8 +2260,10 @@ void RenderThreadImpl::OnMemoryStateChange(base::MemoryState state) {
}
switch (state) {
case base::MemoryState::NORMAL:
+ ResumeRenderer();
break;
case base::MemoryState::THROTTLED:
+ ResumeRenderer();
ReleaseFreeMemory();
break;
case base::MemoryState::SUSPENDED:
@@ -2275,12 +2276,18 @@ void RenderThreadImpl::OnMemoryStateChange(base::MemoryState state) {
}
void RenderThreadImpl::SuspendRenderer() {
+ DCHECK(IsMainThread());
OnTrimMemoryImmediately();
ReleaseFreeMemory();
ClearMemory();
renderer_scheduler_->SuspendRenderer();
}
+void RenderThreadImpl::ResumeRenderer() {
+ DCHECK(IsMainThread());
+ renderer_scheduler_->ResumeRenderer();
+}
+
void RenderThreadImpl::ClearMemory() {
// Do not call into blink if it is not initialized.
if (blink_platform_impl_) {
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698