Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 25773002: Switch Windows to use Skia for text metrics (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years, 2 months ago
CC:
blink-reviews, enne (OOO)
Visibility:
Public.

Description

Switch Windows to use Skia for text metrics Switch the Windows port to use Skia instead of GDI directly for text metrics, font selection and paint setup. BUG=249099 R=reed@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158845

Patch Set 1 #

Patch Set 2 : Merged #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 2 5 chunks +94 lines, -5 lines 0 comments Download
M Source/core/features.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
eae
7 years, 2 months ago (2013-10-02 22:55:37 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-03 08:54:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/25773002/1
7 years, 2 months ago (2013-10-03 14:57:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/25773002/14001
7 years, 2 months ago (2013-10-03 16:41:12 UTC) #4
eae
Committed patchset #3 manually as r158845 (presubmit successful).
7 years, 2 months ago (2013-10-03 23:41:25 UTC) #5
eseidel
This appears to have caused: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Forientation-sideways.html And probably: ast/text/orientation-sideways.html fast/text/international/plane2.html fast/writing-mode/vertical-baseline-alignment.html fast/writing-mode/vertical-align-table-baseline.html Possibly: fast/text/international/complex-text-space-only-glyphpage.html and ...
7 years, 2 months ago (2013-10-07 21:46:31 UTC) #6
eae
7 years, 2 months ago (2013-10-07 21:48:07 UTC) #7
Message was sent while issue was closed.
On 2013/10/07 21:46:31, eseidel wrote:
> This appears to have caused:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> 
> And probably:
> ast/text/orientation-sideways.html
> fast/text/international/plane2.html
> fast/writing-mode/vertical-baseline-alignment.html
> fast/writing-mode/vertical-align-table-baseline.html
> 
> Possibly:
> fast/text/international/complex-text-space-only-glyphpage.html
> and
> svg/text/font-size-below-point-five-2.svg
> svg/transforms/animated-path-inside-transformed-html.xhtml

Thanks. Didn't see those in garden-o-matic. Probably a rebaseline gone wrong.
Looking into it.

Powered by Google App Engine
This is Rietveld 408576698