chrome/browser/icon_loader_win.cc - Issue 2577273002: Clean up IconLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/icon_loader_win.cc

Issue 2577273002: Clean up IconLoader. (Closed)

Patch Set: bind Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/icon_loader_win.cc

diff --git a/chrome/browser/icon_loader_win.cc b/chrome/browser/icon_loader_win.cc

index 0ce1c2190f2e3f61e63558eb36512a4247729510..279c819cc4921be1305b31d9d2ef7a55d8c71c81 100644

--- a/chrome/browser/icon_loader_win.cc

+++ b/chrome/browser/icon_loader_win.cc

@@ -66,7 +66,7 @@ void IconLoader::ReadIcon() {

}

- // Always notify the delegate, regardless of success.

- target_task_runner_->PostTask(FROM_HERE,

- base::Bind(&IconLoader::NotifyDelegate, this));

+ target_task_runner_->PostTask(

+ FROM_HERE, base::Bind(callback_, base::Passed(&image_), group_));

+ delete this;

}

« no previous file with comments | « chrome/browser/icon_loader_mac.mm ('k') | chrome/browser/icon_manager.h » ('j') | no next file with comments »