Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/icon_loader_win.cc

Issue 2577273002: Clean up IconLoader. (Closed)
Patch Set: lifetime fixed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/icon_loader.cc ('K') | « chrome/browser/icon_loader_mac.mm ('k') | chrome/browser/icon_manager.h » ('j') | chrome/browser/icon_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/icon_loader_win.cc
diff --git a/chrome/browser/icon_loader_win.cc b/chrome/browser/icon_loader_win.cc
index 0ce1c2190f2e3f61e63558eb36512a4247729510..de6eeae968cd7a1445a4905baeac1d6cd081cd67 100644
--- a/chrome/browser/icon_loader_win.cc
+++ b/chrome/browser/icon_loader_win.cc
@@ -66,7 +66,8 @@ void IconLoader::ReadIcon() {
}
}
- // Always notify the delegate, regardless of success.
target_task_runner_->PostTask(FROM_HERE,
- base::Bind(&IconLoader::NotifyDelegate, this));
+ base::Bind(callback_, base::Unretained(this),
+ base::Passed(&image_), group_));
+ delete this;
}
« chrome/browser/icon_loader.cc ('K') | « chrome/browser/icon_loader_mac.mm ('k') | chrome/browser/icon_manager.h » ('j') | chrome/browser/icon_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698