Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/icon_loader_win.cc

Issue 2577273002: Clean up IconLoader. (Closed)
Patch Set: bind Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/icon_loader_mac.mm ('k') | chrome/browser/icon_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/icon_loader.h" 5 #include "chrome/browser/icon_loader.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 IconUtil::CreateSkBitmapFromHICON(file_info.hIcon)); 59 IconUtil::CreateSkBitmapFromHICON(file_info.hIcon));
60 if (bitmap.get()) { 60 if (bitmap.get()) {
61 gfx::ImageSkia image_skia(gfx::ImageSkiaRep(*bitmap, 61 gfx::ImageSkia image_skia(gfx::ImageSkiaRep(*bitmap,
62 display::win::GetDPIScale())); 62 display::win::GetDPIScale()));
63 image_skia.MakeThreadSafe(); 63 image_skia.MakeThreadSafe();
64 image_.reset(new gfx::Image(image_skia)); 64 image_.reset(new gfx::Image(image_skia));
65 DestroyIcon(file_info.hIcon); 65 DestroyIcon(file_info.hIcon);
66 } 66 }
67 } 67 }
68 68
69 // Always notify the delegate, regardless of success. 69 target_task_runner_->PostTask(
70 target_task_runner_->PostTask(FROM_HERE, 70 FROM_HERE, base::Bind(callback_, base::Passed(&image_), group_));
71 base::Bind(&IconLoader::NotifyDelegate, this)); 71 delete this;
72 } 72 }
OLDNEW
« no previous file with comments | « chrome/browser/icon_loader_mac.mm ('k') | chrome/browser/icon_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698