Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Side by Side Diff: chrome/browser/icon_loader_mac.mm

Issue 2577273002: Clean up IconLoader. (Closed)
Patch Set: bind Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/icon_loader_chromeos.cc ('k') | chrome/browser/icon_loader_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/icon_loader.h" 5 #include "chrome/browser/icon_loader.h"
6 6
7 #import <AppKit/AppKit.h> 7 #import <AppKit/AppKit.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 default: 45 default:
46 NOTREACHED(); 46 NOTREACHED();
47 } 47 }
48 gfx::ImageSkia image_skia(gfx::ImageSkiaFromResizedNSImage(icon, size)); 48 gfx::ImageSkia image_skia(gfx::ImageSkiaFromResizedNSImage(icon, size));
49 if (!image_skia.isNull()) { 49 if (!image_skia.isNull()) {
50 image_skia.MakeThreadSafe(); 50 image_skia.MakeThreadSafe();
51 image_.reset(new gfx::Image(image_skia)); 51 image_.reset(new gfx::Image(image_skia));
52 } 52 }
53 } 53 }
54 54
55 target_task_runner_->PostTask(FROM_HERE, 55 target_task_runner_->PostTask(
56 base::Bind(&IconLoader::NotifyDelegate, this)); 56 FROM_HERE, base::Bind(callback_, base::Passed(&image_), group_));
57 delete this;
57 } 58 }
OLDNEW
« no previous file with comments | « chrome/browser/icon_loader_chromeos.cc ('k') | chrome/browser/icon_loader_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698