Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tools/perf/page_sets/page_cycler_story.py

Issue 2577243002: Double the navigation timeouts for page cycler stories (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/page_cycler_story.py
diff --git a/tools/perf/page_sets/page_cycler_story.py b/tools/perf/page_sets/page_cycler_story.py
index f3bf387f3445bc8addd24ec70a72dd26e2a81214..5565ac87b15f3c8cf93bf0d4f7de1228a8d3eddd 100644
--- a/tools/perf/page_sets/page_cycler_story.py
+++ b/tools/perf/page_sets/page_cycler_story.py
@@ -6,7 +6,9 @@ from telemetry.page import page
from telemetry.page import cache_temperature as cache_temperature_module
from telemetry.page import shared_page_state
+
_TTI_WAIT_TIME = 10
+_WEB_CONTENTS_TIMEOUT = 180
class PageCyclerStory(page.Page):
@@ -19,6 +21,13 @@ class PageCyclerStory(page.Page):
cache_temperature=cache_temperature,
**kwargs)
+ def RunNavigateSteps(self, action_runner):
+ url = self.file_path_url_with_scheme if self.is_file else self.url
+ action_runner.Navigate(url,
+ self.script_to_evaluate_on_commit,
+ timeout_in_seconds = 120)
+
def RunPageInteractions(self, action_runner):
- action_runner.tab.WaitForDocumentReadyStateToBeComplete()
+ action_runner.tab.WaitForDocumentReadyStateToBeComplete(
+ _WEB_CONTENTS_TIMEOUT)
action_runner.Wait(_TTI_WAIT_TIME)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698