Remove use of WebNode/WebElement in translate_helper

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 1237 matching lines @@
 void Document::setContentLanguage(const AtomicString& language) {
   if (m_contentLanguage == language)
     return;
   m_contentLanguage = language;
 
   // Document's style depends on the content language.
   setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(
                                               StyleChangeReason::Language));
 }
 
+const AtomicString& Document::documentLanguage() const {
+  Element* htmlElement = documentElement();
+  if (!htmlElement) {

[jbroman, 2016/12/16 16:17:42]

super-nit: You don't need the braces here.

[adithyas, 2016/12/16 21:57:17]

Fixed.

+    return nullAtom;
+  }
+  return htmlElement->getAttribute(HTMLNames::langAttr);
+}
+
+Vector<AtomicString> Document::getMetaValues(const AtomicString& name) const {
+  Vector<AtomicString> results;
+
+  HTMLHeadElement* headElement = head();
+  if (!headElement)
+    return results;
+
+  for (Node* child = headElement->firstChild(); child;

[jbroman, 2016/12/16 16:17:42]

You can use the awesome traversal helpers now that you're inside Blink, which
trim some boilerplate from this method.

for (const HTMLMetaElement& metaElement :
Traversal<HTMLMetaElement>::childrenOf(*headElement)) {
  if (metaElement.name() != name)
    continue;
  // and the rest
}

[jbroman, 2016/12/16 16:20:05]

Or "const auto&" instead of "const HTMLMetaElement&", if you think the line
contains the phrase "meta element" too many times already :D

[adithyas, 2016/12/16 21:57:17]

Nice, fixed!

+       child = child->nextSibling()) {
+    if (!isHTMLMetaElement(child))
+      continue;
+    HTMLMetaElement* metaElement = toHTMLMetaElement(child);
+    if (metaElement->name() != name)
+      continue;
+    AtomicString content = metaElement->content();
+    if (content.isNull())
+      results.push_back(metaElement->getAttribute(HTMLNames::valueAttr));
+    else
+      results.push_back(content);

[jbroman, 2016/12/16 16:17:42]

super-nit: I believe AtomicString is movable, so you might as well move the
existing ref into the array:

result.push_back(std::move(content));

[adithyas, 2016/12/16 21:57:17]

Done.

+  }
+
+  return results;
+}
+
 void Document::setXMLVersion(const String& version,
                              ExceptionState& exceptionState) {
   if (!XMLDocumentParser::supportsXMLVersion(version)) {
     exceptionState.throwDOMException(
         NotSupportedError,
         "This document does not support the XML version '" + version + "'.");
     return;
   }
 
   m_xmlVersion = version;
@@ skipping 5304 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif