Allows prefetch requests to live beyond the renderer by delaying

content/browser/loader/resource_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_loader.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
+#include "base/timer/timer.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/loader/cross_site_resource_handler.h"
 #include "content/browser/loader/resource_loader_delegate.h"
 #include "content/browser/loader/resource_request_info_impl.h"
 #include "content/browser/ssl/ssl_client_auth_handler.h"
 #include "content/browser/ssl/ssl_manager.h"
 #include "content/common/ssl_status_serialization.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/resource_dispatcher_host_login_delegate.h"
 #include "content/public/browser/site_instance.h"
@@ skipping 36 matching lines @@
       request,
       &response->head.appcache_id,
       &response->head.appcache_manifest_url);
   // TODO(mmenke):  Figure out if LOAD_ENABLE_LOAD_TIMING is safe to remove.
   if (request->load_flags() & net::LOAD_ENABLE_LOAD_TIMING)
     request->GetLoadTimingInfo(&response->head.load_timing);
 }
 
 }  // namespace
 
+// The time in ms to delay a cancel of a detachable resource unless otherwise
+// specified by a flag.
+static const int kDefaultDelayDetachableCancelMs = 60000;

[mmenke, 2013/10/17 18:33:48]

nit:  Just remove the static and move this up into the namespace above.

[jkarlin2, 2013/10/24 15:33:11]

I needed a settable delay for testing so I removed this and added a member
variable.

+
 ResourceLoader::ResourceLoader(scoped_ptr<net::URLRequest> request,
                                scoped_ptr<ResourceHandler> handler,
                                ResourceLoaderDelegate* delegate)
     : weak_ptr_factory_(this) {
   scoped_ptr<net::ClientCertStore> client_cert_store;
 #if !defined(USE_OPENSSL)
   client_cert_store.reset(new net::ClientCertStoreImpl());
 #endif
   Init(request.Pass(), handler.Pass(), delegate, client_cert_store.Pass());
 }
@@ skipping 374 matching lines @@
   CancelRequest(false);
 }
 
 void ResourceLoader::StartRequestInternal() {
   DCHECK(!request_->is_pending());
   request_->Start();
 
   delegate_->DidStartRequest(this);
 }
 
+bool ResourceLoader::DelayCancelForDetachable(
+    const ResourceRequestInfoImpl& info, bool from_renderer) {

[mmenke, 2013/10/17 18:33:48]

If a profile, along with its network stack, are deleted...How are these
destroyed before the profile's URLRequest context?

[jkarlin2, 2013/10/24 15:33:11]

ResourceContext::~ResourceContext() calls
ResourceDispatcherHostImpl::CancelRequestsForContext

I've added a test to verify that CancelRequestsForContext does immediately kill
detachable requests.

+  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+  // Delay requests to cancel detachable resources. Detachable resources are
+  // those that may need to live beyond the lifetime of their renderers, but
+  // should not be allowed to continue indefinitely as the user cannot control
+  // them through the UI. An example detachable resource is a prefetch.
+  if (from_renderer && !detached_timer_ && info.is_detachable() &&
+      command_line.HasSwitch(switches::kDelayDetachableCancellation)) {
+    // Start the delay timer.
+    detached_timer_.reset(new base::OneShotTimer<ResourceLoader>());
+
+    int delay_ms;
+    if (!base::StringToInt(command_line.GetSwitchValueASCII(
+                               switches::kDelayDetachableCancellation),
+                           &delay_ms)) {
+      delay_ms = kDefaultDelayDetachableCancelMs;
+    }
+
+    detached_timer_->Start(FROM_HERE, TimeDelta::FromMilliseconds(delay_ms),
+                           this, &ResourceLoader::Cancel);
+    return true;
+  }
+  return false;
+}
+
 void ResourceLoader::CancelRequestInternal(int error, bool from_renderer) {
   VLOG(1) << "CancelRequestInternal: " << request_->url().spec();
 
   ResourceRequestInfoImpl* info = GetRequestInfo();
 
   // WebKit will send us a cancel for downloads since it no longer handles
   // them.  In this case, ignore the cancel since we handle downloads in the
   // browser.
   if (from_renderer && (info->is_download() || info->is_stream()))
     return;
 
+  if (DelayCancelForDetachable(*info, from_renderer)) {
+    return;
+  }
+
   // TODO(darin): Perhaps we should really be looking to see if the status is
   // IO_PENDING?
   bool was_pending = request_->is_pending();
 
   if (login_delegate_.get()) {
     login_delegate_->OnRequestCancelled();
     login_delegate_ = NULL;
   }
   if (ssl_client_auth_handler_.get()) {
     ssl_client_auth_handler_->OnRequestCancelled();
@@ skipping 173 matching lines @@
     // we resume.
     deferred_stage_ = DEFERRED_FINISH;
   }
 }
 
 void ResourceLoader::CallDidFinishLoading() {
   delegate_->DidFinishLoading(this);
 }
 
 }  // namespace content