Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: content/browser/loader/resource_loader.cc

Issue 25772002: Allows prefetch requests to live beyond the renderer by delaying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added DetachableType function for generality. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/resource_loader.h" 5 #include "content/browser/loader/resource_loader.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/strings/string_number_conversions.h"
10 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "base/timer/timer.h"
11 #include "content/browser/child_process_security_policy_impl.h" 13 #include "content/browser/child_process_security_policy_impl.h"
12 #include "content/browser/loader/cross_site_resource_handler.h" 14 #include "content/browser/loader/cross_site_resource_handler.h"
13 #include "content/browser/loader/resource_loader_delegate.h" 15 #include "content/browser/loader/resource_loader_delegate.h"
14 #include "content/browser/loader/resource_request_info_impl.h" 16 #include "content/browser/loader/resource_request_info_impl.h"
15 #include "content/browser/ssl/ssl_client_auth_handler.h" 17 #include "content/browser/ssl/ssl_client_auth_handler.h"
16 #include "content/browser/ssl/ssl_manager.h" 18 #include "content/browser/ssl/ssl_manager.h"
17 #include "content/common/ssl_status_serialization.h" 19 #include "content/common/ssl_status_serialization.h"
18 #include "content/public/browser/cert_store.h" 20 #include "content/public/browser/cert_store.h"
19 #include "content/public/browser/resource_dispatcher_host_login_delegate.h" 21 #include "content/public/browser/resource_dispatcher_host_login_delegate.h"
20 #include "content/public/browser/site_instance.h" 22 #include "content/public/browser/site_instance.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 request, 59 request,
58 &response->head.appcache_id, 60 &response->head.appcache_id,
59 &response->head.appcache_manifest_url); 61 &response->head.appcache_manifest_url);
60 // TODO(mmenke): Figure out if LOAD_ENABLE_LOAD_TIMING is safe to remove. 62 // TODO(mmenke): Figure out if LOAD_ENABLE_LOAD_TIMING is safe to remove.
61 if (request->load_flags() & net::LOAD_ENABLE_LOAD_TIMING) 63 if (request->load_flags() & net::LOAD_ENABLE_LOAD_TIMING)
62 request->GetLoadTimingInfo(&response->head.load_timing); 64 request->GetLoadTimingInfo(&response->head.load_timing);
63 } 65 }
64 66
65 } // namespace 67 } // namespace
66 68
69 int ResourceLoader::default_delay_prefetch_cancel_ms_ = 60000;
70
67 ResourceLoader::ResourceLoader(scoped_ptr<net::URLRequest> request, 71 ResourceLoader::ResourceLoader(scoped_ptr<net::URLRequest> request,
68 scoped_ptr<ResourceHandler> handler, 72 scoped_ptr<ResourceHandler> handler,
69 ResourceLoaderDelegate* delegate) 73 ResourceLoaderDelegate* delegate)
70 : weak_ptr_factory_(this) { 74 : weak_ptr_factory_(this) {
71 scoped_ptr<net::ClientCertStore> client_cert_store; 75 scoped_ptr<net::ClientCertStore> client_cert_store;
72 #if !defined(USE_OPENSSL) 76 #if !defined(USE_OPENSSL)
73 client_cert_store.reset(new net::ClientCertStoreImpl()); 77 client_cert_store.reset(new net::ClientCertStoreImpl());
74 #endif 78 #endif
75 Init(request.Pass(), handler.Pass(), delegate, client_cert_store.Pass()); 79 Init(request.Pass(), handler.Pass(), delegate, client_cert_store.Pass());
76 } 80 }
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 CancelRequest(false); 455 CancelRequest(false);
452 } 456 }
453 457
454 void ResourceLoader::StartRequestInternal() { 458 void ResourceLoader::StartRequestInternal() {
455 DCHECK(!request_->is_pending()); 459 DCHECK(!request_->is_pending());
456 request_->Start(); 460 request_->Start();
457 461
458 delegate_->DidStartRequest(this); 462 delegate_->DidStartRequest(this);
459 } 463 }
460 464
465 bool ResourceLoader::DelayCancelForPrefetch(const ResourceRequestInfoImpl& info,
466 bool from_renderer) {
467 // Delay requests to cancel prefetches
468 const CommandLine& command_line = *CommandLine::ForCurrentProcess();
469
470 if (from_renderer && !prefetch_timer_ &&
471 info.GetResourceType() == ResourceType::PREFETCH &&
472 command_line.HasSwitch(switches::kDelayPrefetchCancellation)) {
473 // Our first call to cancel this prefetch, start a delay timer.
474 prefetch_timer_.reset(new base::OneShotTimer<ResourceLoader>());
475
476 int delay_ms;
477 if (!base::StringToInt(command_line.GetSwitchValueASCII(
478 switches::kDelayPrefetchCancellation),
479 &delay_ms)) {
480 delay_ms = default_delay_prefetch_cancel_ms_;
481 }
482
483 prefetch_timer_->Start(FROM_HERE, TimeDelta::FromMilliseconds(delay_ms),
484 this, &ResourceLoader::Cancel);
485 return true;
486 }
487 return false;
488 }
489
461 void ResourceLoader::CancelRequestInternal(int error, bool from_renderer) { 490 void ResourceLoader::CancelRequestInternal(int error, bool from_renderer) {
462 VLOG(1) << "CancelRequestInternal: " << request_->url().spec(); 491 VLOG(1) << "CancelRequestInternal: " << request_->url().spec();
463 492
464 ResourceRequestInfoImpl* info = GetRequestInfo(); 493 ResourceRequestInfoImpl* info = GetRequestInfo();
465 494
466 // WebKit will send us a cancel for downloads since it no longer handles 495 // WebKit will send us a cancel for downloads since it no longer handles
467 // them. In this case, ignore the cancel since we handle downloads in the 496 // them. In this case, ignore the cancel since we handle downloads in the
468 // browser. 497 // browser.
469 if (from_renderer && (info->is_download() || info->is_stream())) 498 if (from_renderer && (info->is_download() || info->is_stream()))
470 return; 499 return;
471 500
501 if (DelayCancelForPrefetch(*info, from_renderer)) {
502 return;
503 }
504
472 // TODO(darin): Perhaps we should really be looking to see if the status is 505 // TODO(darin): Perhaps we should really be looking to see if the status is
473 // IO_PENDING? 506 // IO_PENDING?
474 bool was_pending = request_->is_pending(); 507 bool was_pending = request_->is_pending();
475 508
476 if (login_delegate_.get()) { 509 if (login_delegate_.get()) {
477 login_delegate_->OnRequestCancelled(); 510 login_delegate_->OnRequestCancelled();
478 login_delegate_ = NULL; 511 login_delegate_ = NULL;
479 } 512 }
480 if (ssl_client_auth_handler_.get()) { 513 if (ssl_client_auth_handler_.get()) {
481 ssl_client_auth_handler_->OnRequestCancelled(); 514 ssl_client_auth_handler_->OnRequestCancelled();
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 // we resume. 688 // we resume.
656 deferred_stage_ = DEFERRED_FINISH; 689 deferred_stage_ = DEFERRED_FINISH;
657 } 690 }
658 } 691 }
659 692
660 void ResourceLoader::CallDidFinishLoading() { 693 void ResourceLoader::CallDidFinishLoading() {
661 delegate_->DidFinishLoading(this); 694 delegate_->DidFinishLoading(this);
662 } 695 }
663 696
664 } // namespace content 697 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698