Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3067)

Unified Diff: base/files/file_util_win.cc

Issue 2577163002: A follow-up nit fix for jumplist file operations (Closed)
Patch Set: Fix nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_util_posix.cc ('k') | chrome/browser/win/jumplist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_util_win.cc
diff --git a/base/files/file_util_win.cc b/base/files/file_util_win.cc
index 629658447d848b53630c2638d4ae478990ba498b..4e67b5a348653f3af41d897f845ce4e0df4f2571 100644
--- a/base/files/file_util_win.cc
+++ b/base/files/file_util_win.cc
@@ -177,12 +177,8 @@ bool CopyDirectory(const FilePath& from_path, const FilePath& to_path,
FilePath real_from_path = MakeAbsoluteFilePath(from_path);
if (real_from_path.empty())
return false;
- // Note: it's important to use IsParent() here as string comparison would
- // result in a false negative, e.g. on C:\bar\Foo versus C:\bar\FooOld.
- if (real_to_path.value().size() >= real_from_path.value().size() &&
- real_from_path.IsParent(real_to_path)) {
+ if (real_to_path == real_from_path || real_from_path.IsParent(real_to_path))
return false;
- }
int traverse_type = FileEnumerator::FILES;
if (recursive)
« no previous file with comments | « base/files/file_util_posix.cc ('k') | chrome/browser/win/jumplist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698