Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2577083002: Add test for Nullable-By-Default (Null is subtype of all types). (Closed)

Created:
4 years ago by Lasse Reichstein Nielsen
Modified:
3 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for Nullable-By-Default (Null is subtype of all types). R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/cbf69e80b471d3f9e06fd041f788abe48ab1c41c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix test, address comments. #

Patch Set 3 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M tests/language/language.status View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A tests/language/null_bottom_test.dart View 1 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
Initial version
4 years ago (2016-12-15 15:35:28 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2577083002/diff/1/tests/language/null_bottom_test.dart File tests/language/null_bottom_test.dart (right): https://codereview.chromium.org/2577083002/diff/1/tests/language/null_bottom_test.dart#newcode10 tests/language/null_bottom_test.dart:10: bool checkedMode = () { bool c = ...
4 years ago (2016-12-20 10:52:58 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/2577083002/diff/1/tests/language/null_bottom_test.dart File tests/language/null_bottom_test.dart (right): https://codereview.chromium.org/2577083002/diff/1/tests/language/null_bottom_test.dart#newcode10 tests/language/null_bottom_test.dart:10: bool checkedMode = () { bool c = false; ...
3 years, 11 months ago (2017-01-02 12:48:51 UTC) #4
Lasse Reichstein Nielsen
@johnniwinther FYI
3 years, 11 months ago (2017-01-02 12:49:50 UTC) #5
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-04 13:20:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cbf69e80b471d3f9e06fd041f788abe48ab1c41c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698