third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 2577053002: ActiveScriptWrappable: GC wrappers in detached ExecutionContexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 2577053002: ActiveScriptWrappable: GC wrappers in detached ExecutionContexts. (Closed)

Patch Set: component build fix(msvc) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h ('k') | third_party/WebKit/Source/modules/speech/SpeechRecognition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index a5dce4e380ba4d5967db5a888377cfa2d35aa76a..5b4d1066fcdfb54dd73b7e791cee939f7a31a150 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -132,7 +132,7 @@ ScriptPromise ServiceWorkerRegistration::unregister(ScriptState* scriptState) {

ServiceWorkerRegistration::ServiceWorkerRegistration(

ExecutionContext* executionContext,

std::unique_ptr<WebServiceWorkerRegistration::Handle> handle)

- : ActiveScriptWrappable(this),

+ : ActiveScriptWrappable<ServiceWorkerRegistration>(this),

SuspendableObject(executionContext),

m_handle(std::move(handle)),

m_stopped(false) {