third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2577053002: ActiveScriptWrappable: GC wrappers in detached ExecutionContexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2577053002: ActiveScriptWrappable: GC wrappers in detached ExecutionContexts. (Closed)

Patch Set: component build fix(msvc) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index e86617dfde0b0a59ceddba71c191435c12891b8a..d81b1b5252b972fd767e9ea633f27aa00a898171 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -50,8 +50,8 @@ const WrapperTypeInfo& {{cpp_class}}::s_wrapperTypeInfo = {{v8_class}}::wrapperT

{% if active_scriptwrappable %}

// [ActiveScriptWrappable]

static_assert(

- std::is_base_of<ActiveScriptWrappable, {{cpp_class}}>::value,

- "{{cpp_class}} does not inherit from ActiveScriptWrappable, but specifying "

+ std::is_base_of<ActiveScriptWrappableBase, {{cpp_class}}>::value,

+ "{{cpp_class}} does not inherit from ActiveScriptWrappable<>, but specifying "

"[ActiveScriptWrappable] extended attribute in the IDL file. "

"Be consistent.");

static_assert(

@@ -63,8 +63,8 @@ static_assert(

{% else %}

// not [ActiveScriptWrappable]

static_assert(

- !std::is_base_of<ActiveScriptWrappable, {{cpp_class}}>::value,

- "{{cpp_class}} inherits from ActiveScriptWrappable, but is not specifying "

+ !std::is_base_of<ActiveScriptWrappableBase, {{cpp_class}}>::value,

+ "{{cpp_class}} inherits from ActiveScriptWrappable<>, but is not specifying "

"[ActiveScriptWrappable] extended attribute in the IDL file. "

"Be consistent.");

static_assert(