Cast: Print out AV sync in cast receiver if playing test video

Cast: Print out AV sync in cast receiver if playing test video

Test videos can be found in chrome/test/data/extensions/api_test/cast_streaming/test_video_*fps.webm

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266300

[miu, 2014-04-25 06:47:59]

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver.cc
File media/cast/test/receiver.cc (right):

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver...
media/cast/test/receiver.cc:299: if (is_continuous && frame_no ==
last_audio_frame_no_ + 1) {
What is supposed to happen if !is_continuous?  Seems like you should always test
for frame_no >= last_audio_frame_no_ + 1, irrespective of is_continuous.

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver...
media/cast/test/receiver.cc:482: VLOG(0) << "AV sync: " << (delta /
num_events).InMilliseconds() << "ms";
After "AV sync:" can you add "audio behind by"?

[hubbe, 2014-04-25 07:21:38]

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver.cc
File media/cast/test/receiver.cc (right):

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver...
media/cast/test/receiver.cc:299: if (is_continuous && frame_no ==
last_audio_frame_no_ + 1) {
On 2014/04/25 06:47:59, miu wrote:
> What is supposed to happen if !is_continuous?  Seems like you should always
test
> for frame_no >= last_audio_frame_no_ + 1, irrespective of is_continuous.

Comment added.
Basically, we're supposed to ignore this audio/video frame for the purpose of
calculating AV sync if that happens.

https://codereview.chromium.org/257703002/diff/20001/media/cast/test/receiver...
media/cast/test/receiver.cc:482: VLOG(0) << "AV sync: " << (delta /
num_events).InMilliseconds() << "ms";
On 2014/04/25 06:47:59, miu wrote:
> After "AV sync:" can you add "audio behind by"?

Changed it to just say "Audio behind by:".

[miu, 2014-04-25 07:29:42]

lgtm

[hubbe, 2014-04-25 08:11:06]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-04-25 08:32:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hubbe@chromium.org/257703002/30001

[commit-bot: I haz the power, 2014-04-26 00:21:38]

Change committed as 266300