MD Settings: actually fix sync Learn More click issues

chrome/browser/resources/settings/people_page/sync_page.js

Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index 699855008d18c5ad57a1a03b83b970ecac251b71..f96e752cb0950cac04eebfeccf746a575671ac16 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -47,7 +47,6 @@ Polymer({
   is: 'settings-sync-page',
 
   behaviors: [
-    I18nBehavior,

[Dan Beam, 2016/12/15 06:00:20]

not used, afaict

     WebUIListenerBehavior,
     settings.RouteObserverBehavior,
   ],
@@ -292,14 +291,6 @@ Polymer({
   },
 
   /**
-   * @param {!Event} e
-   * @private
-   */
-  onSyncLearnMoreTap_: function(e) {

[Dan Beam, 2016/12/15 06:00:20]

annnnd there's another one of these JUST like this handler ... in the same file

shame cube

-    e.stopPropagation();
-  },
-
-  /**
    * Sends the newly created custom sync passphrase to the browser.
    * @private
    */
@@ -434,9 +425,11 @@ Polymer({
    * @private
    */
   onLearnMoreTap_: function(event) {
-    // Stop the propagation of events, so that clicking on links inside
-    // checkbox labels won't change the checkbox value.
-    event.stopPropagation();
+    if (event.target.tagName == 'A') {
+      // Stop the propagation of events, so that clicking on links inside
+      // checkbox labels won't change the checkbox value.
+      event.stopPropagation();
+    }
   }
 });