MD Settings: actually fix sync Learn More click issues

chrome/browser/resources/settings/people_page/sync_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 /**
  * Names of the radio buttons which allow the user to choose their encryption
  * mechanism.
  * @enum {string}
@@ skipping 29 matching lines @@
  *
  *    <iron-animated-pages>
  *      <settings-sync-page></settings-sync-page>
  *      ... other pages ...
  *    </iron-animated-pages>
  */
 Polymer({
   is: 'settings-sync-page',
 
   behaviors: [
-    I18nBehavior,
     WebUIListenerBehavior,
     settings.RouteObserverBehavior,
   ],
 
   properties: {
     /** @private */
     pages: {
       type: Object,
       value: settings.PageStatus,
       readOnly: true,
@@ skipping 224 matching lines @@
    * @param {string} passphrase The passphrase input field value
    * @param {string} confirmation The passphrase confirmation input field value.
    * @return {boolean} Whether the passphrase save button should be enabled.
    * @private
    */
   isSaveNewPassphraseEnabled_: function(passphrase, confirmation) {
     return passphrase !== '' && confirmation !== '';
   },
 
   /**
-   * @param {!Event} e
-   * @private
-   */
-  onSyncLearnMoreTap_: function(e) {
-    e.stopPropagation();
-  },
-
-  /**
    * Sends the newly created custom sync passphrase to the browser.
    * @private
    */
   onSaveNewPassphraseTap_: function() {
     assert(this.creatingNewPassphrase_);
 
     // If a new password has been entered but it is invalid, do not send the
     // sync state to the API.
     if (!this.validateCreatedPassphrases_())
       return;
@@ skipping 114 matching lines @@
         !emptyPassphrase && mismatchedPassphrase;
 
     return !emptyPassphrase && !mismatchedPassphrase;
   },
 
   /**
    * @param {!Event} event
    * @private
    */
   onLearnMoreTap_: function(event) {
-    // Stop the propagation of events, so that clicking on links inside
-    // checkbox labels won't change the checkbox value.
-    event.stopPropagation();
+    if (event.target.tagName == 'A') {
+      // Stop the propagation of events, so that clicking on links inside
+      // checkbox labels won't change the checkbox value.

[tommycli, 2016/12/15 16:08:33]

nit: update comment since it applies to radio control labels now too

[Dan Beam, 2016/12/16 01:24:40]

Done.

+      event.stopPropagation();
+    }
   }
 });
 
 })();