Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Unified Diff: chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc

Issue 2576973003: Fix a crash when typing in an exo window. (Closed)
Patch Set: Add comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc
diff --git a/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc b/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc
index 76869b1c0e8e141390161ec3f3073b212c280cf9..a852b57ef7b476765b2dcb6eaa330e848ff59505 100644
--- a/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc
+++ b/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc
@@ -39,7 +39,11 @@ void InputMethodBridge::ProcessKeyEvent(
input_method_chromeos_->DispatchKeyEvent(
key_event, base::MakeUnique<base::Callback<void(bool)>>(callback));
} else {
- callback.Run(false);
+ // On Linux (include ChromeOS), the mus emulates the WM_CHAR generation
sky 2016/12/15 16:54:14 This seems like a work around. Unnecessarily consu
Peng 2016/12/15 17:24:36 On Window, the char events are consumed by InputMe
+ // behaviour of Windows. But for ChromeOS, we don't expect those char
+ // events, so we filter them out.
+ const bool handled = true;
+ callback.Run(handled);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698