Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: appengine/gaeconfig/cache.go

Issue 2576923003: Implement config service cache on top of datastore (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/gaeconfig/default.go » ('j') | appengine/gaeconfig/ds.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/gaeconfig/cache.go
diff --git a/appengine/gaeconfig/cache.go b/appengine/gaeconfig/cache.go
index 06743dcdc21300c2bc3f0509bfba372577a9c8e3..5e2fadd088c3e3be66caca6c9154f59163461be7 100644
--- a/appengine/gaeconfig/cache.go
+++ b/appengine/gaeconfig/cache.go
@@ -81,11 +81,7 @@ func memcacheBackend(b config.Backend, exp time.Duration) config.Backend {
default:
// Unknown memcache error.
- log.Fields{
- log.ErrorKey: err,
- "key": k,
- }.Warningf(c, "Failed to decode memcached config.")
- return l(c, key, nil)
+ return nil, errors.Annotate(err).Reason("failed to load memcache config").Err()
}
},
}
« no previous file with comments | « no previous file | appengine/gaeconfig/default.go » ('j') | appengine/gaeconfig/ds.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698