third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2576903002: [EditCommandSource] Pass source from |Editor::Command| to |Editor::apply*()/insert*()/...| (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2576903002: [EditCommandSource] Pass source from |Editor::Command| to |Editor::apply*()/insert*()/...| (2/3) (Closed)

Patch Set: Xiaocheng's review: Add TODOs and DCHECK comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 1a5df9e1694116fe3d7a8000063f7a83cc057b89..f5956be27377a5b84a7451218fcacb1c73e1d367 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -6510,8 +6510,7 @@ TEST_P(ParameterizedWebFrameTest, CancelSpellingRequestCrash) {

WebSettings::EditingBehaviorWin);

element->focus();

- frame->frame()->editor().replaceSelectionWithText(

- "A", false, false, InputEvent::InputType::InsertReplacementText);

+ frame->frame()->editor().replaceSelectionForSpellChecker("A");

frame->frame()->spellChecker().cancelCheck();

}