fpdfsdk/fpdfxfa/cpdfxfa_context.cpp - Issue 2576893002: Return unique_ptr from CXFA_FFApp::CreateDoc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

Issue 2576893002: Return unique_ptr from CXFA_FFApp::CreateDoc. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

index 1995882388b457364d0c281501b4e62c34f91901..7a0ffeb256f64a3024f71c93d10ff80b72b4d01b 100644

--- a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

+++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

@@ -92,7 +92,7 @@ bool CPDFXFA_Context::LoadXFADoc() {

if (!pApp)

return false;

- m_pXFADoc.reset(pApp->CreateDoc(&m_DocEnv, m_pPDFDoc.get()));

+ m_pXFADoc = pApp->CreateDoc(&m_DocEnv, m_pPDFDoc.get());

if (!m_pXFADoc) {

SetLastError(FPDF_ERR_XFALOAD);

return false;

« no previous file with comments | « fpdfsdk/fpdfview.cpp ('k') | xfa/fxfa/app/xfa_ffapp.cpp » ('j') | no next file with comments »