Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc

Issue 2576843002: [win] Create ModuleDatabase and ModuleEventSinkImpl. (Closed)
Patch Set: Rework OnProcessStarted. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
diff --git a/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc b/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..69df853068866f1ae9f7aca2e28eaabef38dd524
--- /dev/null
+++ b/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
@@ -0,0 +1,83 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/conflicts/module_event_sink_impl_win.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/conflicts/module_database_win.h"
+#include "chrome/common/conflicts/module_watcher_win.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// The address of this module in memory. The linker will take care of defining
+// this symbol.
+extern "C" IMAGE_DOS_HEADER __ImageBase;
+
+// An invalid load address.
+const uint64_t kInvalidLoadAddress = 0xDEADBEEF;
+
+} // namespace
+
+class ModuleEventSinkImplTest : public testing::Test {
+ protected:
+ ModuleEventSinkImplTest()
+ : message_loop_(new base::MessageLoop),
grt (UTC plus 2) 2016/12/20 11:11:35 base::MakeUnique?
chrisha 2016/12/20 19:46:24 See previous response.
chrisha 2016/12/21 20:15:00 (Done.)
+ module_database_(new ::ModuleDatabase(message_loop_->task_runner())) {}
+
+ void CreateModuleSinkImpl() {
+ module_event_sink_impl_ = base::MakeUnique<ModuleEventSinkImpl>(
+ ::GetCurrentProcess(), content::PROCESS_TYPE_BROWSER,
+ module_database_.get());
+ }
+
+ ModuleDatabase* module_database() {
+ return module_event_sink_impl_->module_database_;
+ }
+
+ const ModuleDatabase::ModuleSet& modules() {
+ return module_database_->modules_;
+ }
+
+ const ModuleDatabase::ProcessSet& processes() {
+ return module_database_->processes_;
+ }
+
+ uint32_t process_id() { return module_event_sink_impl_->process_id_; }
+
+ std::unique_ptr<base::MessageLoop> message_loop_;
grt (UTC plus 2) 2016/12/20 11:11:35 #include <memory>
chrisha 2016/12/20 19:46:24 Done.
+ std::unique_ptr<ModuleDatabase> module_database_;
+ std::unique_ptr<ModuleEventSinkImpl> module_event_sink_impl_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ModuleEventSinkImplTest);
+};
+
+TEST_F(ModuleEventSinkImplTest, CallsForwardedAsExpected) {
+ const uintptr_t kValidLoadAddress = reinterpret_cast<uintptr_t>(&__ImageBase);
+
+ EXPECT_EQ(0u, modules().size());
+ EXPECT_EQ(0u, processes().size());
+
+ // Construction should immediately fire off a call to OnProcessStarted and
+ // create a process entry in the module database.
+ CreateModuleSinkImpl();
+ EXPECT_EQ(module_database_.get(), module_database());
+ EXPECT_EQ(::GetCurrentProcessId(), process_id());
+ EXPECT_EQ(0u, modules().size());
+ EXPECT_EQ(1u, processes().size());
+
+ // An invalid load event should not cause a module entry.
+ module_event_sink_impl_->OnModuleEvent(
+ mojom::ModuleEventType::MODULE_ALREADY_LOADED, kInvalidLoadAddress);
+ EXPECT_EQ(0u, modules().size());
+ EXPECT_EQ(1u, processes().size());
+
+ // A valid load event should cause a module entry.
+ module_event_sink_impl_->OnModuleEvent(mojom::ModuleEventType::MODULE_LOADED,
+ kValidLoadAddress);
+ EXPECT_EQ(1u, modules().size());
+ EXPECT_EQ(1u, processes().size());
+}

Powered by Google App Engine
This is Rietveld 408576698