Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chrome/browser/conflicts/module_database_win.h" | |
| 6 | |
| 7 #include "base/bind.h" | |
| 8 #include "base/message_loop/message_loop.h" | |
| 9 #include "base/run_loop.h" | |
| 10 #include "base/strings/utf_string_conversions.h" | |
| 11 #include "base/threading/simple_thread.h" | |
| 12 #include "testing/gtest/include/gtest/gtest.h" | |
| 13 | |
| 14 namespace { | |
| 15 | |
| 16 // A simple mechanism for running a single task on a separate thread. | |
| 17 class SingleTaskRunner : public base::SimpleThread { | |
| 18 public: | |
| 19 explicit SingleTaskRunner(const base::Closure& task) | |
| 20 : base::SimpleThread("SingleTaskRunner"), task_(task) {} | |
| 21 | |
| 22 // Runs the provided task and exits. | |
| 23 void Run() override { task_.Run(); } | |
| 24 | |
| 25 private: | |
| 26 base::Closure task_; | |
| 27 DISALLOW_COPY_AND_ASSIGN(SingleTaskRunner); | |
| 28 }; | |
| 29 | |
| 30 // Launches a thread and runs a single task on it. | |
| 31 void RunTask(const base::Closure& task) { | |
| 32 SingleTaskRunner task_runner(task); | |
| 33 task_runner.Start(); | |
| 34 task_runner.Join(); | |
| 35 } | |
| 36 | |
| 37 // Factory for mojom::ModuleEvents. | |
| 38 mojom::ModuleEvent ModuleEvent(mojom::ModuleEventType type, | |
| 39 const char* path, | |
| 40 uint64_t address, | |
| 41 uint32_t size) { | |
| 42 mojom::ModuleEvent event; | |
| 43 event.event_type = type; | |
| 44 event.module_path = std::string(path); | |
| 45 event.load_address = address; | |
| 46 event.size = size; | |
| 47 return event; | |
| 48 } | |
| 49 | |
| 50 const char kDummyDll[] = "dummy.dll"; | |
| 51 const char kFooDll[] = "foo.dll"; | |
| 52 | |
| 53 } // namespace | |
| 54 | |
| 55 class ModuleDatabaseTest : public testing::Test { | |
| 56 public: | |
|
grt (UTC plus 2)
2016/12/15 09:07:12
nit: protected
chrisha
2016/12/19 20:15:37
Done.
| |
| 57 ModuleDatabaseTest() | |
| 58 : message_loop_(new base::MessageLoop), | |
| 59 module_database_(new ModuleDatabase(message_loop_->task_runner())) {} | |
| 60 | |
| 61 void RunLoopUntilIdle() { | |
| 62 base::RunLoop run_loop; | |
| 63 run_loop.RunUntilIdle(); | |
| 64 } | |
| 65 | |
| 66 const ModuleDatabase::ModuleSet& modules() { | |
| 67 return module_database_->modules_; | |
| 68 } | |
| 69 | |
| 70 const ModuleDatabase::ProcessSet& processes() { | |
| 71 return module_database_->processes_; | |
| 72 } | |
| 73 | |
| 74 static uint32_t ProcessTypeToBit(content::ProcessType process_type) { | |
| 75 return ModuleDatabase::ProcessTypeToBit(process_type); | |
| 76 } | |
| 77 | |
| 78 std::unique_ptr<base::MessageLoop> message_loop_; | |
| 79 std::unique_ptr<ModuleDatabase> module_database_; | |
| 80 }; | |
| 81 | |
| 82 TEST_F(ModuleDatabaseTest, TasksAreBounced) { | |
| 83 // Run a task on the current thread. This should not be bounced, so no | |
| 84 // task should be scheduled on the task runner. | |
| 85 module_database_->OnProcessStarted(1234, content::PROCESS_TYPE_BROWSER); | |
| 86 EXPECT_TRUE(message_loop_->IsIdleForTesting()); | |
| 87 module_database_->OnModuleEvent( | |
| 88 1234, ModuleEvent(mojom::ModuleEventType::MODULE_LOADED, kDummyDll, | |
| 89 0xBAADF00D, 100 * 4096)); | |
| 90 EXPECT_TRUE(message_loop_->IsIdleForTesting()); | |
| 91 module_database_->OnProcessEnded(1234); | |
| 92 EXPECT_TRUE(message_loop_->IsIdleForTesting()); | |
| 93 | |
| 94 // Run similar tasks on another thread. These should be bounced. | |
| 95 RunTask(base::Bind(&ModuleDatabase::OnProcessStarted, | |
| 96 base::Unretained(module_database_.get()), 2345, | |
| 97 content::PROCESS_TYPE_BROWSER)); | |
| 98 EXPECT_FALSE(message_loop_->IsIdleForTesting()); | |
| 99 RunLoopUntilIdle(); | |
| 100 | |
| 101 RunTask(base::Bind(&ModuleDatabase::OnModuleEvent, | |
| 102 base::Unretained(module_database_.get()), 2345, | |
| 103 ModuleEvent(mojom::ModuleEventType::MODULE_LOADED, | |
| 104 kDummyDll, 0xDEADBEEF, 10 * 4096))); | |
| 105 EXPECT_FALSE(message_loop_->IsIdleForTesting()); | |
| 106 RunLoopUntilIdle(); | |
| 107 | |
| 108 RunTask(base::Bind(&ModuleDatabase::OnProcessEnded, | |
| 109 base::Unretained(module_database_.get()), 2345)); | |
| 110 EXPECT_FALSE(message_loop_->IsIdleForTesting()); | |
| 111 RunLoopUntilIdle(); | |
| 112 } | |
| 113 | |
| 114 TEST_F(ModuleDatabaseTest, DatabaseIsConsistent) { | |
| 115 EXPECT_EQ(0u, modules().size()); | |
| 116 EXPECT_EQ(0u, processes().size()); | |
| 117 | |
| 118 // Start a process. | |
| 119 module_database_->OnProcessStarted(1234, content::PROCESS_TYPE_BROWSER); | |
| 120 EXPECT_EQ(0u, modules().size()); | |
| 121 EXPECT_EQ(1u, processes().size()); | |
| 122 auto p1 = processes().begin(); | |
| 123 EXPECT_EQ(1234, p1->process_id); | |
| 124 EXPECT_EQ(content::PROCESS_TYPE_BROWSER, p1->process_type); | |
| 125 EXPECT_EQ(0u, p1->loaded_module_ids.size()); | |
| 126 EXPECT_EQ(0u, p1->unloaded_module_ids.size()); | |
| 127 | |
| 128 // Indicate an already loaded module. | |
| 129 module_database_->OnModuleEvent( | |
| 130 1234, ModuleEvent(mojom::ModuleEventType::MODULE_ALREADY_LOADED, | |
| 131 kDummyDll, 0xBAADF00D, 100 * 4096)); | |
| 132 EXPECT_EQ(1u, modules().size()); | |
| 133 EXPECT_EQ(1u, processes().size()); | |
| 134 | |
| 135 // Ensure that the process and module sets are up to date. | |
| 136 auto m1 = modules().begin(); | |
| 137 EXPECT_EQ(base::UTF8ToWide(kDummyDll), m1->module_path.value()); | |
| 138 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m1->process_types); | |
| 139 EXPECT_EQ(1234, p1->process_id); | |
| 140 EXPECT_EQ(content::PROCESS_TYPE_BROWSER, p1->process_type); | |
| 141 EXPECT_EQ(1u, p1->loaded_module_ids.size()); | |
| 142 EXPECT_EQ(0u, p1->unloaded_module_ids.size()); | |
| 143 EXPECT_EQ(1u, p1->loaded_module_ids.count(m1->module_id)); | |
| 144 | |
| 145 // Provide a redundant load message for that module. | |
| 146 module_database_->OnModuleEvent( | |
| 147 1234, ModuleEvent(mojom::ModuleEventType::MODULE_LOADED, kDummyDll, | |
| 148 0xBAADF00D, 100 * 4096)); | |
| 149 EXPECT_EQ(1u, modules().size()); | |
| 150 EXPECT_EQ(1u, processes().size()); | |
| 151 | |
| 152 // Ensure that the process and module sets haven't changed. | |
| 153 EXPECT_EQ(base::UTF8ToWide(kDummyDll), m1->module_path.value()); | |
| 154 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m1->process_types); | |
| 155 EXPECT_EQ(1234, p1->process_id); | |
| 156 EXPECT_EQ(content::PROCESS_TYPE_BROWSER, p1->process_type); | |
| 157 EXPECT_EQ(1u, p1->loaded_module_ids.size()); | |
| 158 EXPECT_EQ(0u, p1->unloaded_module_ids.size()); | |
| 159 EXPECT_EQ(1u, p1->loaded_module_ids.count(m1->module_id)); | |
| 160 | |
| 161 // Load a second module into the process. | |
| 162 module_database_->OnModuleEvent( | |
| 163 1234, ModuleEvent(mojom::ModuleEventType::MODULE_LOADED, kFooDll, | |
| 164 0xDEADBEEF, 20 * 4096)); | |
| 165 EXPECT_EQ(2u, modules().size()); | |
| 166 EXPECT_EQ(1u, processes().size()); | |
| 167 | |
| 168 // Ensure that the process and module sets are up to date. | |
| 169 auto m2 = modules().rbegin(); | |
| 170 EXPECT_EQ(base::UTF8ToWide(kFooDll), m2->module_path.value()); | |
| 171 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m2->process_types); | |
| 172 EXPECT_EQ(1234, p1->process_id); | |
| 173 EXPECT_EQ(content::PROCESS_TYPE_BROWSER, p1->process_type); | |
| 174 EXPECT_EQ(2u, p1->loaded_module_ids.size()); | |
| 175 EXPECT_EQ(0u, p1->unloaded_module_ids.size()); | |
| 176 EXPECT_EQ(1u, p1->loaded_module_ids.count(m1->module_id)); | |
| 177 EXPECT_EQ(1u, p1->loaded_module_ids.count(m2->module_id)); | |
| 178 | |
| 179 // Unload the second module. | |
| 180 module_database_->OnModuleEvent( | |
| 181 1234, ModuleEvent(mojom::ModuleEventType::MODULE_UNLOADED, kFooDll, | |
| 182 0xDEADBEEF, 20 * 4096)); | |
| 183 EXPECT_EQ(2u, modules().size()); | |
| 184 EXPECT_EQ(1u, processes().size()); | |
| 185 | |
| 186 // Ensure that the process and module sets are up to date. | |
| 187 EXPECT_EQ(base::UTF8ToWide(kFooDll), m2->module_path.value()); | |
| 188 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m2->process_types); | |
| 189 EXPECT_EQ(1234, p1->process_id); | |
| 190 EXPECT_EQ(content::PROCESS_TYPE_BROWSER, p1->process_type); | |
| 191 EXPECT_EQ(1u, p1->loaded_module_ids.size()); | |
| 192 EXPECT_EQ(1u, p1->unloaded_module_ids.size()); | |
| 193 EXPECT_EQ(1u, p1->loaded_module_ids.count(m1->module_id)); | |
| 194 EXPECT_EQ(1u, p1->unloaded_module_ids.count(m2->module_id)); | |
| 195 | |
| 196 // Start a process. | |
| 197 module_database_->OnProcessStarted(2345, content::PROCESS_TYPE_RENDERER); | |
| 198 EXPECT_EQ(2u, modules().size()); | |
| 199 EXPECT_EQ(2u, processes().size()); | |
| 200 auto p2 = processes().rbegin(); | |
| 201 EXPECT_EQ(2345, p2->process_id); | |
| 202 EXPECT_EQ(content::PROCESS_TYPE_RENDERER, p2->process_type); | |
| 203 EXPECT_EQ(0u, p2->loaded_module_ids.size()); | |
| 204 EXPECT_EQ(0u, p2->unloaded_module_ids.size()); | |
| 205 | |
| 206 // Load the dummy.dll in the second process as well. | |
| 207 module_database_->OnModuleEvent( | |
| 208 2345, ModuleEvent(mojom::ModuleEventType::MODULE_ALREADY_LOADED, | |
| 209 kDummyDll, 0xBAADF00D, 100 * 4096)); | |
| 210 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER) | | |
| 211 ProcessTypeToBit(content::PROCESS_TYPE_RENDERER), | |
| 212 m1->process_types); | |
| 213 EXPECT_EQ(2345, p2->process_id); | |
| 214 EXPECT_EQ(content::PROCESS_TYPE_RENDERER, p2->process_type); | |
| 215 EXPECT_EQ(1u, p2->loaded_module_ids.size()); | |
| 216 EXPECT_EQ(0u, p2->unloaded_module_ids.size()); | |
| 217 EXPECT_EQ(1u, p2->loaded_module_ids.count(m1->module_id)); | |
| 218 | |
| 219 // End the second process without an explicit unload. This invalidates |p2|. | |
| 220 module_database_->OnProcessEnded(2345); | |
| 221 EXPECT_EQ(2u, modules().size()); | |
| 222 EXPECT_EQ(1u, processes().size()); | |
| 223 EXPECT_EQ(1234, p1->process_id); | |
| 224 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER) | | |
| 225 ProcessTypeToBit(content::PROCESS_TYPE_RENDERER), | |
| 226 m1->process_types); | |
| 227 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m2->process_types); | |
| 228 | |
| 229 // End the first process without an explicit unload. This invalidates |p1|. | |
| 230 module_database_->OnProcessEnded(1234); | |
| 231 EXPECT_EQ(2u, modules().size()); | |
| 232 EXPECT_EQ(0u, processes().size()); | |
| 233 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER) | | |
| 234 ProcessTypeToBit(content::PROCESS_TYPE_RENDERER), | |
| 235 m1->process_types); | |
| 236 EXPECT_EQ(ProcessTypeToBit(content::PROCESS_TYPE_BROWSER), m2->process_types); | |
| 237 } | |
| OLD | NEW |