Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: extensions/browser/image_loader.h

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/image_loader.h
diff --git a/extensions/browser/image_loader.h b/extensions/browser/image_loader.h
index 3a7c1b4c607024d1b5ece976d77522758fc49538..cf3c407264a6e7a6aed57a4c08a6c55fb0101365 100644
--- a/extensions/browser/image_loader.h
+++ b/extensions/browser/image_loader.h
@@ -80,11 +80,20 @@ class ImageLoader : public KeyedService {
// if the image was found in the cache.
// Note this method loads a raw bitmap from the resource. All sizes given are
// assumed to be in pixels.
+ // TODO(estade): remove this in favor of LoadImageAtEveryScaleFactorAsync,
+ // and rename the later to LoadImageAsync.
Devlin 2016/12/15 17:14:41 s/later/latter
Evan Stade 2016/12/15 23:49:02 Done.
void LoadImageAsync(const extensions::Extension* extension,
const ExtensionResource& resource,
const gfx::Size& max_size,
const ImageLoaderImageCallback& callback);
+ // Loads and returns a gfx::Image that has representations at all supported
+ // scale factors.
+ void LoadImageAtEveryScaleFactorAsync(
+ const extensions::Extension* extension,
Devlin 2016/12/15 17:14:41 no need for extensions:: prefix.
Evan Stade 2016/12/15 23:49:02 Done.
+ const gfx::Size& dip_size,
+ const ImageLoaderImageCallback& callback);
+
// Same as LoadImageAsync() above except it loads multiple images from the
// same extension. This is used to load multiple resolutions of the same image
// type.

Powered by Google App Engine
This is Rietveld 408576698