Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2137)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2576813002: Disable WEBGL_compressed_texture_etc1 on WebGL 1 on ANGLE (Closed)
Patch Set: update expectations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index ba7eccf1fe955142439699b0e313807f7b63b3f9..2c90605fd1bceef6b586a377368b4f9430b35743 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1024,7 +1024,11 @@ void FeatureInfo::InitializeFeatures() {
validators_.g_l_state.AddValue(GL_TEXTURE_BINDING_EXTERNAL_OES);
}
- if (extensions.Contains("GL_OES_compressed_ETC1_RGB8_texture")) {
+ // TODO(kainino): If we add a way to query whether ANGLE is exposing
+ // native support for ETC1 textures, require that here. Otherwise, we could
+ // co-opt the native-ETC2-support query discussed below.
+ if (extensions.Contains("GL_OES_compressed_ETC1_RGB8_texture") &&
+ !gl_version_info_->is_angle) {
AddExtensionString("GL_OES_compressed_ETC1_RGB8_texture");
feature_flags_.oes_compressed_etc1_rgb8_texture = true;
validators_.compressed_texture_format.AddValue(GL_ETC1_RGB8_OES);

Powered by Google App Engine
This is Rietveld 408576698