Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: tools/gn/xcode_object.h

Issue 2576773002: [Refactor Xcode Objects] Enable navigator paths for file references. (Closed)
Patch Set: update convert_gn_xcodeproj.py Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/xcode_object.h
diff --git a/tools/gn/xcode_object.h b/tools/gn/xcode_object.h
index 2ad43cceefc4567abad8d2ca2123794f0c0cf606..58b1df7cd04ef5cd8596e2acc34a0c1b38736b7e 100644
--- a/tools/gn/xcode_object.h
+++ b/tools/gn/xcode_object.h
@@ -218,7 +218,9 @@ class PBXGroup : public PBXObject {
const std::string& path() const { return path_; }
PBXObject* AddChild(std::unique_ptr<PBXObject> child);
- PBXFileReference* AddSourceFile(const std::string& source_path);
+ PBXFileReference* AddSourceFile(const std::string& navigator_path,
+ const std::string& source_path);
+ void SetIsSource(const bool is_source) { is_source_ = is_source; }
sdefresne 2016/12/16 23:47:58 I think it should be called "set_is_source" accord
liaoyuke 2016/12/19 08:04:39 Done.
// PBXObject implementation.
PBXObjectClass Class() const override;
@@ -230,6 +232,7 @@ class PBXGroup : public PBXObject {
std::vector<std::unique_ptr<PBXObject>> children_;
std::string name_;
std::string path_;
+ bool is_source_ = false;
DISALLOW_COPY_AND_ASSIGN(PBXGroup);
};
@@ -271,7 +274,8 @@ class PBXProject : public PBXObject {
const PBXAttributes& attributes);
~PBXProject() override;
- void AddSourceFile(const std::string& source_path);
+ void AddSourceFile(const std::string& navigator_path,
+ const std::string& source_path);
void AddAggregateTarget(const std::string& name,
const std::string& shell_script);
void AddNativeTarget(const std::string& name,

Powered by Google App Engine
This is Rietveld 408576698