Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(388)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: url/url_canon_icu_alternatives_android.h
Issue
257673002
:
Make it possible to build url/ without ICU on android. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change how failures are handled
Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
build/common.gypi
components/cronet/android/cronet_jni.cc
net/test/run_all_unittests.cc
url/BUILD.gn
url/DEPS
url/android/java/src/org/chromium/url/IDNStringUtil.java
url/android/url_jni_registrar.h
url/android/url_jni_registrar.cc
url/url.gyp
url/url_canon_icu_alternatives_android.h
url/url_canon_icu_alternatives_android.cc
url/url_canon_icu_unittest.cc
url/url_canon_unittest.cc
url/url_srcs.gypi
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« url/BUILD.gn
('K') |
« url/url.gyp
('k') |
url/url_canon_icu_alternatives_android.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2014 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#ifndef URL_URL_CANON_ICU_ALTERNATIVES_ANDROID_H_
6
#define URL_URL_CANON_ICU_ALTERNATIVES_ANDROID_H_
7
8
#include <jni.h>
9
10
namespace url {
11
12
// Explicitly register static JNI functions needed when not using ICU.
13
bool RegisterIcuAlternativesJni(JNIEnv* env);
14
15
} // namespace url
16
17
#endif // URL_URL_CANON_ICU_ALTERNATIVES_ANDROID_H_
18
OLD
NEW
« url/BUILD.gn
('K') |
« url/url.gyp
('k') |
url/url_canon_icu_alternatives_android.cc »
('j') |
no next file with comments »
Issue 257673002: Make it possible to build url/ without ICU on android. (Closed)
Created 6 years, 8 months ago by mmenke
Modified 6 years, 7 months ago
Reviewers: mef, brettw
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 25
This is Rietveld
408576698
Chromium Code Reviews
Issue 257673002:
Make it possible to build url/ without ICU on android. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src