Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: url/BUILD.gn

Issue 257673002: Make it possible to build url/ without ICU on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix GN/GYP Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 component("url") { 5 component("url") {
6 if (is_win) { 6 if (is_win) {
7 # Don't conflict with Windows' "url.dll". 7 # Don't conflict with Windows' "url.dll".
8 output_name = "url_lib" 8 output_name = "url_lib"
9 } 9 }
10 sources = [ 10 sources = [
11 "android/url_jni_registrar.cc",
mef 2014/05/01 19:45:15 should this go into some android-specific section?
mmenke 2014/05/01 21:01:33 Files that have platform names in their paths aren
mef 2014/05/02 15:10:48 sgtm. I thought it only applied to name suffix, ni
12 "android/url_jni_registrar.h",
11 "gurl.cc", 13 "gurl.cc",
12 "gurl.h", 14 "gurl.h",
13 "third_party/mozilla/url_parse.cc", 15 "third_party/mozilla/url_parse.cc",
14 "third_party/mozilla/url_parse.h", 16 "third_party/mozilla/url_parse.h",
15 "url_canon.h", 17 "url_canon.h",
16 "url_canon_etc.cc", 18 "url_canon_etc.cc",
17 "url_canon_filesystemurl.cc", 19 "url_canon_filesystemurl.cc",
18 "url_canon_fileurl.cc", 20 "url_canon_fileurl.cc",
19 "url_canon_host.cc", 21 "url_canon_host.cc",
20 "url_canon_icu.cc", 22 "url_canon_icu.cc",
(...skipping 24 matching lines...) Expand all
45 # if (is_win) { 47 # if (is_win) {
46 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 48 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
47 # 'msvs_disabled_warnings': [ 4267, ] 49 # 'msvs_disabled_warnings': [ 4267, ]
48 # } 50 # }
49 51
50 deps = [ 52 deps = [
51 "//base", 53 "//base",
52 "//third_party/icu:icudata", 54 "//third_party/icu:icudata",
53 "//third_party/icu", 55 "//third_party/icu",
54 ] 56 ]
57
58 if (use_icu_alternatives) {
59 sources -= [
60 "url_canon_icu.cc",
61 "url_canon_icu.h",
62 ]
63 deps -= [
64 "//third_party/icu:icudata",
65 "//third_party/icu",
66 ]
67
68 if (is_android) {
69 sources += [
70 "url_canon_icu_alternatives_android.cc",
71 "url_canon_icu_alternatives_android.h",
72 ]
73 }
74 }
55 } 75 }
56 76
57 # TODO(dpranke): crbug.com/360936. Get this to build and run on Android. 77 # TODO(dpranke): crbug.com/360936. Get this to build and run on Android.
58 if (!is_android) { 78 if (!is_android) {
59 test("url_unittests") { 79 test("url_unittests") {
60 sources = [ 80 sources = [
61 "gurl_unittest.cc", 81 "gurl_unittest.cc",
82 "url_canon_icu_unittest.cc",
62 "url_canon_unittest.cc", 83 "url_canon_unittest.cc",
63 "url_parse_unittest.cc", 84 "url_parse_unittest.cc",
64 "url_test_utils.h", 85 "url_test_utils.h",
65 "url_util_unittest.cc", 86 "url_util_unittest.cc",
66 ] 87 ]
67 88
68 #if (is_posix && !is_mac && !is_ios) { 89 #if (is_posix && !is_mac && !is_ios) {
69 # # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 90 # # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
70 # if ((use_allocator!="none" && use_allocator!="see_use_tcmalloc") || (use_ allocator=="see_use_tcmalloc" && linux_use_tcmalloc) { 91 # if ((use_allocator!="none" && use_allocator!="see_use_tcmalloc") || (use_ allocator=="see_use_tcmalloc" && linux_use_tcmalloc) {
71 # deps += "//base/allocator" 92 # deps += "//base/allocator"
72 # } 93 # }
73 #} 94 #}
74 95
75 # if (is_win) { 96 # if (is_win) {
76 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 97 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
77 # 'msvs_disabled_warnings': [ 4267, ] 98 # 'msvs_disabled_warnings': [ 4267, ]
78 # } 99 # }
79 100
80 deps = [ 101 deps = [
81 ":url", 102 ":url",
82 "//base:i18n", 103 "//base:i18n",
83 "//base/test:run_all_unittests", 104 "//base/test:run_all_unittests",
84 "//testing/gtest", 105 "//testing/gtest",
85 "//third_party/icu:icuuc", 106 "//third_party/icu:icuuc",
86 ] 107 ]
108
109 if (use_icu_alternatives) {
110 sources -= [
111 "url_canon_icu_unittest.cc",
112 ]
113 deps -= [
114 "//base:i18n",
115 "//third_party/icu:icuuc",
116 ]
117
118 if (is_android) {
119 sources += [
120 "url_canon_icu_alternatives_android.cc",
121 ]
122 }
123 }
87 } 124 }
88 } 125 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698