Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25767003: Revert "document.documentElement.scrollTop/Left is zero" (Closed)

Created:
7 years, 2 months ago by rafaelw
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "document.documentElement.scrollTop/Left is zero" This reverts https://src.chromium.org/viewvc/blink?revision=158719&view=revision This patch was breaking telemetry unittests (scrollAction: e.g. http://build.chromium.org/p/chromium.webkit/builders/Vista%20Tests/builds/33554/steps/telemetry_unittests/logs/stdio) and blocking the blink roll in chromium. TBR=jchaffraix@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -209 lines) Patch
M LayoutTests/fast/css/zoom-body-scroll.html View 1 chunk +6 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/Element/resources/scrollable-iframe-quirks.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M LayoutTests/fast/dom/anchor-without-content.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/mouse-cursor.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/mouse-cursor-image-set.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates.html View 3 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-editable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-editable-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html View 3 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/navigation/anchor-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/navigation/anchor-frames-same-origin-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/frame-with-anchor.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/mac/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/rubberbanding/momentum-reset.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rafaelw
Committed patchset #1 manually as r158749 (presubmit successful).
7 years, 2 months ago (2013-10-02 20:15:01 UTC) #1
rafaelw
7 years, 2 months ago (2013-10-02 20:15:09 UTC) #2
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698