Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 25767002: Inline SuddenTermination.h into the one file that uses it. (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Inline SuddenTermination.h into the one file that uses it. There's no reason for all this ceremony now that we can depend on public/platform directly. R=eseidel@chromium.org, eseidel BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -90 lines) Patch
M Source/core/.gitattributes View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 2 chunks +11 lines, -1 line 0 comments Download
D Source/core/platform/SuddenTermination.h View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/core/platform/chromium/SuddenTerminationChromium.cpp View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-02 17:55:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25767002/1
7 years, 2 months ago (2013-10-02 17:55:37 UTC) #2
eseidel
lgtm
7 years, 2 months ago (2013-10-02 18:00:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8302
7 years, 2 months ago (2013-10-02 22:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25767002/1
7 years, 2 months ago (2013-10-02 22:51:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8361
7 years, 2 months ago (2013-10-03 01:16:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25767002/1
7 years, 2 months ago (2013-10-03 01:29:14 UTC) #7
abarth-chromium
7 years, 2 months ago (2013-10-03 03:54:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r158771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698