Start re-trying dartk compilations if they crash

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 3694509fd0e28ec2b5824a4ea6c16bf24192c0a9..ef36efdb2dc87814f635d60583c1fcf10121d7ae 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -233,6 +233,8 @@ class KernelCompilationCommand extends CompilationCommand {
       : super._(displayName, outputFile, neverSkipCompilation,
                 bootstrapDependencies, executable, arguments,
                 environmentOverrides);
+
+  int get maxNumRetries => 1;
 }
 
 /// This is just a Pair(String, Map) class with hashCode and operator ==
@@ -2841,6 +2843,23 @@ bool shouldRetryCommand(CommandOutput output) {
       }
     }
 
+    final command = output.command;
+
+    // The dartk batch compiler sometimes runs out of memory. In such a case we
+    // will retry running it.
+    if (command is KernelCompilationCommand) {
+      if (output.hasCrashed) {

[Vyacheslav Egorov (Google), 2016/12/14 13:49:49]

Can we grep output for out of memory instead of retrying all crashes?

Retrying all might hide bugs in the  long running VM/dartk

[kustermann, 2016/12/15 11:37:18]

Done.

+        return true;
+      }
+    }
+
+    // We currently rerun dartium tests, see issue 14074.
+    if (command is BrowserTestCommand &&
+        command.retry &&
+        command.browser == 'dartium') {
+      return true;
+    }
+
     if (io.Platform.operatingSystem == 'linux') {
       decodeOutput();
       // No matter which command we ran: If we get failures due to the
@@ -2854,13 +2873,6 @@ bool shouldRetryCommand(CommandOutput output) {
       }
     }
 
-    // We currently rerun dartium tests, see issue 14074.
-    final command = output.command;
-    if (command is BrowserTestCommand &&
-        command.retry &&
-        command.browser == 'dartium') {
-      return true;
-    }
   }
   return false;
 }