Start re-trying dartk compilations if they crash

Start re-trying dartk compilations if they crash

Every crash of a dartk invocation will cause 1 more re-try. This is independent
of whether the crash was caused by the entire batch runner or just that single
compilation caused an exception.

The unfortunate side-effect of this is that ./tools/test.py will now print
warnings every time it retries the command.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e9f0db2ba1e1a5ade3753a946f0796202e614bbd

[kustermann, 2016-12-14 13:22:34]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-12-14 13:49:50]

https://codereview.chromium.org/2576693002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2576693002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:2851: if (output.hasCrashed) {
Can we grep output for out of memory instead of retrying all crashes?

Retrying all might hide bugs in the  long running VM/dartk

[Vyacheslav Egorov (Google), 2016-12-14 13:50:56]

lgtm otherwise.

[kustermann, 2016-12-15 11:37:18]

https://codereview.chromium.org/2576693002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2576693002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:2851: if (output.hasCrashed) {
On 2016/12/14 13:49:49, Vyacheslav Egorov (Google) wrote:
> Can we grep output for out of memory instead of retrying all crashes?
> 
> Retrying all might hide bugs in the  long running VM/dartk

Done.

[kustermann, 2016-12-15 11:37:30]

Description was changed from

==========
Start re-trying dartk compilations if they crash

Every crash of a dartk invocation will cause 1 more re-try. This is independent
of whether the crash was caused by the entire batch runner or just that single
compilation caused an exception.

The unfortunate side-effect of this is that ./tools/test.py will now print
warnings every time it retries the command.
==========

to

==========
Start re-trying dartk compilations if they crash

Every crash of a dartk invocation will cause 1 more re-try. This is independent
of whether the crash was caused by the entire batch runner or just that single
compilation caused an exception.

The unfortunate side-effect of this is that ./tools/test.py will now print
warnings every time it retries the command.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e9f0db2ba1e1a5ade3753a946f0796202e614bbd
==========

[kustermann, 2016-12-15 11:37:31]

Committed patchset #2 (id:20001) manually as
e9f0db2ba1e1a5ade3753a946f0796202e614bbd (presubmit successful).