Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2576663003: Log only valid occurences of 'All native types used ...'. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Log only valid occurences of 'All native types used ...'. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8d4553ae46439350e66e9cf14824c62874c8e84f

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/all_native_test.dart View 1 1 chunk +25 lines, -0 lines 1 comment Download
M tests/compiler/dart2js/diagnostic_helper.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2576663003/diff/20001/tests/compiler/dart2js/all_native_test.dart File tests/compiler/dart2js/all_native_test.dart (right): https://codereview.chromium.org/2576663003/diff/20001/tests/compiler/dart2js/all_native_test.dart#newcode23 tests/compiler/dart2js/all_native_test.dart:23: 1, allNativeUsedCount, "Unexpected message count: $allNativeUsedCount"); Count before the ...
4 years ago (2016-12-14 09:00:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years ago (2016-12-14 16:00:52 UTC) #3
Johnni Winther
4 years ago (2016-12-16 08:50:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8d4553ae46439350e66e9cf14824c62874c8e84f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698