| Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
|
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
|
| index e5cdadee8ec7d86aebbddf5c0aee2122bbd71404..2285e0cdb46e291a114e6153b2be750c3ce23eb4 100644
|
| --- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
|
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
|
| @@ -28,6 +28,7 @@ import java.lang.annotation.Retention;
|
| import java.lang.annotation.RetentionPolicy;
|
| import java.util.List;
|
| import java.util.Locale;
|
| +import java.util.concurrent.TimeUnit;
|
|
|
| /**
|
| * Provides methods for building the X-Geo HTTP header, which provides device location to a server
|
| @@ -152,6 +153,14 @@ public class GeolocationHeader {
|
| @IntDef({PERMISSION_GRANTED, PERMISSION_PROMPT, PERMISSION_BLOCKED})
|
| private @interface Permission {}
|
|
|
| + /** The maximum value for the GeolocationHeader.TimeListening* histograms. */
|
| + public static final int TIME_LISTENING_HISTOGRAM_MAX_MILLIS = 50 * 60 * 1000; // 50 minutes
|
| +
|
| + /** The maximum value for the GeolocationHeader.LocationAge* histograms.
|
| + * Using 24 days as that is the highest number of days that does not overflow int.
|
| + */
|
| + public static final int LOCATION_AGE_HISTOGRAM_MAX_MILLIS = 24 * 24 * 60 * 60 * 1000;
|
| +
|
| /** The maximum age in milliseconds of a location that we'll send in an X-Geo header. */
|
| private static final int MAX_LOCATION_AGE = 24 * 60 * 60 * 1000; // 24 hours
|
|
|
| @@ -160,6 +169,9 @@ public class GeolocationHeader {
|
|
|
| private static final String HTTPS_SCHEME = "https";
|
|
|
| + /** The time of the first location refresh. Contains Long.MAX_VALUE if not set. */
|
| + private static long sFirstLocationTime = Long.MAX_VALUE;
|
| +
|
| /**
|
| * Requests a location refresh so that a valid location will be available for constructing
|
| * an X-Geo header in the near future (i.e. within 5 minutes).
|
| @@ -169,6 +181,9 @@ public class GeolocationHeader {
|
| public static void primeLocationForGeoHeader(Context context) {
|
| if (!hasGeolocationPermission(context)) return;
|
|
|
| + if (sFirstLocationTime == Long.MAX_VALUE) {
|
| + sFirstLocationTime = System.currentTimeMillis();
|
| + }
|
| GeolocationTracker.refreshLastKnownLocation(context, REFRESH_LOCATION_AGE);
|
| }
|
|
|
| @@ -227,6 +242,7 @@ public class GeolocationHeader {
|
| boolean isIncognito = tab.isIncognito();
|
| boolean locationAttached = true;
|
| Location location = null;
|
| + long locationAge = Long.MAX_VALUE;
|
| if (isGeoHeaderEnabledForUrl(context, url, isIncognito, true)) {
|
| // Only send X-Geo header if there's a fresh location available.
|
| location = GeolocationTracker.getLastKnownLocation(context);
|
| @@ -234,7 +250,8 @@ public class GeolocationHeader {
|
| recordHistogram(UMA_LOCATION_NOT_AVAILABLE);
|
| locationAttached = false;
|
| } else {
|
| - if (GeolocationTracker.getLocationAge(location) > MAX_LOCATION_AGE) {
|
| + locationAge = GeolocationTracker.getLocationAge(location);
|
| + if (locationAge > MAX_LOCATION_AGE) {
|
| recordHistogram(UMA_LOCATION_STALE);
|
| locationAttached = false;
|
| }
|
| @@ -251,6 +268,17 @@ public class GeolocationHeader {
|
| recordPermissionHistogram(
|
| locationSource, appPermission, domainPermission, locationAttached);
|
|
|
| + if (locationSource != LOCATION_SOURCE_MASTER_OFF && appPermission != PERMISSION_BLOCKED
|
| + && domainPermission != PERMISSION_BLOCKED) {
|
| + // Record the Location Age with a histogram.
|
| + recordLocationAgeHistogram(locationSource, locationAge);
|
| + long duration = sFirstLocationTime == Long.MAX_VALUE
|
| + ? Long.MAX_VALUE
|
| + : System.currentTimeMillis() - sFirstLocationTime;
|
| + // Record the Time Listening with a histogram.
|
| + recordTimeListeningHistogram(locationSource, locationAttached, duration);
|
| + }
|
| +
|
| // Note that strictly speaking "location == null" is not needed here as the
|
| // logic above prevents location being null when locationAttached is true.
|
| // It is here to prevent problems if the logic above is changed.
|
| @@ -530,4 +558,52 @@ public class GeolocationHeader {
|
| RecordHistogram.recordEnumeratedHistogram(
|
| "Geolocation.Header.PermissionState", result, UMA_PERM_COUNT);
|
| }
|
| +
|
| + /** Determines the name for a Time Listening Histogram. Returns empty string if the location
|
| + * source is MASTER_OFF as we do not record histograms for that case.
|
| + */
|
| + private static String getTimeListeningHistogramEnum(
|
| + int locationSource, boolean locationAttached) {
|
| + switch (locationSource) {
|
| + case LOCATION_SOURCE_HIGH_ACCURACY:
|
| + return locationAttached
|
| + ? "Geolocation.Header.TimeListeningHighAccuracyLocationAttached"
|
| + : "Geolocation.Header.TimeListeningHighAccuracyLocationNotAttached";
|
| + case LOCATION_SOURCE_GPS_ONLY:
|
| + return locationAttached
|
| + ? "Geolocation.Header.TimeListeningGpsOnlyLocationAttached"
|
| + : "Geolocation.Header.TimeListeningGpsOnlyLocationNotAttached";
|
| + case LOCATION_SOURCE_BATTERY_SAVING:
|
| + return locationAttached
|
| + ? "Geolocation.Header.TimeListeningBatterySavingLocationAttached"
|
| + : "Geolocation.Header.TimeListeningBatterySavingLocationNotAttached";
|
| + default:
|
| + return "";
|
| + }
|
| + }
|
| +
|
| + /** Records a data point for one of the GeolocationHeader.TimeListening* histograms. */
|
| + private static void recordTimeListeningHistogram(
|
| + int locationSource, boolean locationAttached, long duration) {
|
| + String name = getTimeListeningHistogramEnum(locationSource, locationAttached);
|
| + if (name.equals("")) return;
|
| + RecordHistogram.recordCustomTimesHistogram(
|
| + name, duration, 1, TIME_LISTENING_HISTOGRAM_MAX_MILLIS, TimeUnit.MILLISECONDS, 50);
|
| + }
|
| +
|
| + /** Records a data point for one of the GeolocationHeader.LocationAge* histograms. */
|
| + private static void recordLocationAgeHistogram(int locationSource, long duration) {
|
| + String name = "";
|
| + if (locationSource == LOCATION_SOURCE_HIGH_ACCURACY) {
|
| + name = "Geolocation.Header.LocationAgeHighAccuracy";
|
| + } else if (locationSource == LOCATION_SOURCE_GPS_ONLY) {
|
| + name = "Geolocation.Header.LocationAgeGpsOnly";
|
| + } else if (locationSource == LOCATION_SOURCE_BATTERY_SAVING) {
|
| + name = "Geolocation.Header.LocationAgeBatterySaving";
|
| + } else {
|
| + return;
|
| + }
|
| + RecordHistogram.recordCustomTimesHistogram(
|
| + name, duration, 1, LOCATION_AGE_HISTOGRAM_MAX_MILLIS, TimeUnit.MILLISECONDS, 50);
|
| + }
|
| }
|
|
|