tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 686021c772acdef887fefc302993b362f62fff11..f219ccfc2039bd59266326d34052ac4d1d0be9f3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19356,6 +19356,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Geolocation.Header.LocationAgeBatterySaving">

[Ilya Sherman, 2016/12/15 01:45:13]

Please add a units attribute, here and for the other histograms as well.

[Ilya Sherman, 2016/12/15 01:45:13]

nit: I'd recommend having a dot between "LocationAge" and "BatterySaving"

[Ilya Sherman, 2016/12/15 01:45:13]

Please use histogram_suffixes element(s) to reduce the amount of metadata
repetition in this file.

[pdyson, 2016/12/15 05:31:00]

Done units.

Added dots after "LocationAge" here and "TimeListening" below.

Added histogram_suffixes for LocationAge and TimeListening. TimeListening is
still repetitive. Can two sets of suffixes be applied to TimeListening?

+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was most recently acquired. This histogram is for location mode
+    Battery Saving.

[Ilya Sherman, 2016/12/15 01:45:13]

Please  document what is recorded when the location has not yet been obtained,
or that this case is not possible.

[pdyson, 2016/12/15 05:31:00]

Done.

+  </summary>
+</histogram>
+
+<histogram name="Geolocation.Header.LocationAgeGpsOnly">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was most recently acquired. This histogram is for location mode GPS
+    Only.
+  </summary>
+</histogram>
+
+<histogram name="Geolocation.Header.LocationAgeHighAccuracy">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was most recently acquired. This histogram is for location mode
+    High Accuracy.
+  </summary>
+</histogram>
+
 <histogram name="Geolocation.Header.PermissionState"
     enum="GeolocationHeaderPermissionState">
   <owner>kcarattini@chromium.org</owner>
@@ -19367,6 +19397,68 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Geolocation.Header.TimeListeningBatterySavingLocationAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode Battery
+    Saving when the location was successfully attached to the request.
+  </summary>
+</histogram>
+
+<histogram
+    name="Geolocation.Header.TimeListeningBatterySavingLocationNotAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode Battery
+    Saving when the location was not attached to the request.

[Ilya Sherman, 2016/12/15 01:45:13]

Why might the location not be attached, if it was acquired?

[pdyson, 2016/12/15 05:31:00]

I've added in the reasons.

+  </summary>
+</histogram>
+
+<histogram name="Geolocation.Header.TimeListeningGpsOnlyLocationAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode GPS Only
+    when the location was successfully attached to the request.
+  </summary>
+</histogram>
+
+<histogram name="Geolocation.Header.TimeListeningGpsOnlyLocationNotAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode GPS Only
+    when the location was not attached to the request.
+  </summary>
+</histogram>
+
+<histogram name="Geolocation.Header.TimeListeningHighAccuracyLocationAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode High
+    Accuracy when the location was successfully attached to the request.
+  </summary>
+</histogram>
+
+<histogram
+    name="Geolocation.Header.TimeListeningHighAccuracyLocationNotAttached">
+  <owner>kcarattini@chromium.org</owner>
+  <owner>dominickn@chromium.org</owner>
+  <summary>
+    For Geolocation requests from the omnibox on Android, the time since the
+    location was first acquired. This histogram is for location mode High
+    Accuracy when the location was not attached to the request.
+  </summary>
+</histogram>
+
 <histogram name="Geolocation.InfoBarDelegate.Event"
     enum="GeolocationInfoBarDelegateEvent">
   <obsolete>