Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257663002: A Google AppEngine test server to facilitate chromeproxy Telemetry tests. (Closed)

Created:
6 years, 8 months ago by bolian
Modified:
6 years, 7 months ago
Reviewers:
bengr, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

A Google AppEngine test server to facilitate chromeproxy Telemetry tests. BUG=320748 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268275

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments. #

Total comments: 2

Patch Set 3 : moved to tools/chromeproxy_testserver #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, --1 lines) Patch
A + tools/chromeproxy_testserver/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/chromeproxy_testserver/app.yaml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A tools/chromeproxy_testserver/data/image1.png View 1 2 Binary file 0 comments Download
A tools/chromeproxy_testserver/image/image1.png View 1 2 Binary file 0 comments Download
A tools/chromeproxy_testserver/server.go View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download
A tools/chromeproxy_testserver/server_test.go View 1 2 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
bolian
Hi Tony, We have a GAE test server for some of the chromeproxy tests. Would ...
6 years, 8 months ago (2014-04-24 18:35:40 UTC) #1
bengr
https://codereview.chromium.org/257663002/diff/1/tools/perf/chromeproxy_testserver/OWNERS File tools/perf/chromeproxy_testserver/OWNERS (right): https://codereview.chromium.org/257663002/diff/1/tools/perf/chromeproxy_testserver/OWNERS#newcode1 tools/perf/chromeproxy_testserver/OWNERS:1: bolian@chromium.org add marq@ and bengr@ too. https://codereview.chromium.org/257663002/diff/1/tools/perf/chromeproxy_testserver/server.go File tools/perf/chromeproxy_testserver/server.go ...
6 years, 8 months ago (2014-04-25 20:30:34 UTC) #2
bolian
https://codereview.chromium.org/257663002/diff/1/tools/perf/chromeproxy_testserver/OWNERS File tools/perf/chromeproxy_testserver/OWNERS (right): https://codereview.chromium.org/257663002/diff/1/tools/perf/chromeproxy_testserver/OWNERS#newcode1 tools/perf/chromeproxy_testserver/OWNERS:1: bolian@chromium.org On 2014/04/25 20:30:34, bengr1 wrote: > add marq@ ...
6 years, 7 months ago (2014-04-30 17:35:34 UTC) #3
bolian
Hi Tony, Do you have a better place to land this test server for chrome ...
6 years, 7 months ago (2014-04-30 17:36:42 UTC) #4
bengr
lgtm with a nit. https://codereview.chromium.org/257663002/diff/10001/tools/perf/chromeproxy_testserver/server.go File tools/perf/chromeproxy_testserver/server.go (right): https://codereview.chromium.org/257663002/diff/10001/tools/perf/chromeproxy_testserver/server.go#newcode9 tools/perf/chromeproxy_testserver/server.go:9: // The goal is to ...
6 years, 7 months ago (2014-05-01 17:57:31 UTC) #5
bolian
https://codereview.chromium.org/257663002/diff/10001/tools/perf/chromeproxy_testserver/server.go File tools/perf/chromeproxy_testserver/server.go (right): https://codereview.chromium.org/257663002/diff/10001/tools/perf/chromeproxy_testserver/server.go#newcode9 tools/perf/chromeproxy_testserver/server.go:9: // The goal is to keep the test logic ...
6 years, 7 months ago (2014-05-02 05:00:27 UTC) #6
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-05-02 16:46:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/257663002/50001
6 years, 7 months ago (2014-05-02 16:46:53 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 17:22:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 17:22:01 UTC) #10
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-05-02 17:35:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/257663002/50001
6 years, 7 months ago (2014-05-02 17:36:35 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 18:13:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 18:13:38 UTC) #14
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-05-02 20:38:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/257663002/50001
6 years, 7 months ago (2014-05-02 20:39:20 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:59:19 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:59:20 UTC) #18
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-05-05 18:24:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/257663002/50001
6 years, 7 months ago (2014-05-05 18:25:31 UTC) #20
commit-bot: I haz the power
Change committed as 268275
6 years, 7 months ago (2014-05-05 21:35:20 UTC) #21
bolian
6 years, 7 months ago (2014-05-05 21:53:21 UTC) #22
Message was sent while issue was closed. 
wrong bug. should be 320748.

Powered by Google App Engine
This is Rietveld 408576698