Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page_manager.js

Issue 2576603002: bluetooth: Add device details page with basic properties to internals page. (Closed)
Patch Set: Fix formatting, fix comments, fix test, change service/rssi display Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/bluetooth_internals_browsertest.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/page_manager/page_manager.js
diff --git a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
index 99599b1ed2ce8d87eca1c0d30744159b25fe4e79..40907226ec0af3c2389b5263e0d0b52dbed9150d 100644
--- a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
+++ b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
@@ -83,6 +83,14 @@ cr.define('cr.ui.pageManager', function() {
},
/**
+ * Unregisters an existing page.
+ * @param {!cr.ui.pageManager.Page} page Page to unregister.
+ */
+ unregister: function(page) {
+ delete this.registeredPages[page.name.toLowerCase()];
dpapad 2017/01/12 22:53:21 Is it necessary to unregister a page? I am wonderi
mbrunson 2017/01/12 23:09:19 Unregistering a page can create an obsolete entry
+ },
+
+ /**
* Registers a new Overlay page.
* @param {!cr.ui.pageManager.Page} overlay Overlay to register.
* @param {cr.ui.pageManager.Page} parentPage Associated parent page for
« no previous file with comments | « chrome/test/data/webui/bluetooth_internals_browsertest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698