bluetooth: Add device details page with basic properties to internals page.

chrome/browser/resources/bluetooth_internals/device_table.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for DeviceTable UI, served from chrome://bluetooth-internals/.
  */
 
 cr.define('device_table', function() {
   var COLUMNS = {
     NAME: 0,
     ADDRESS: 1,
     RSSI: 2,
     SERVICES: 3,
     CONNECTION_STATE: 4,
-    INSPECT_LINK: 5,
+    LINKS: 5,

[scheib, 2017/01/11 02:16:14]

In screenshot the links column doesn't have a header cell, and looks a bit odd
IMHO without one. Maybe it doesn't need text as a label, but having the top
header row be full width would be visually nicer.

[mbrunson, 2017/01/11 21:22:59]

Done.

   };
 
   /**
    * A table that lists the devices and responds to changes in the given
    * DeviceCollection. Fires events for inspection requests from listed
    * devices.
    * @constructor
    * @extends {HTMLTableElement}
    */
   var DeviceTable = cr.ui.define(function() {
@@ skipping 27 matching lines @@
 
       this.devices_ = deviceCollection;
       this.devices_.addEventListener('sorted', this.redraw_.bind(this));
       this.devices_.addEventListener('change', this.handleChange_.bind(this));
       this.devices_.addEventListener('splice', this.handleSplice_.bind(this));
 
       this.redraw_();
     },
 
     /**
+     * Fires a forget pressed event for the row |index|.
+     * @param {number} index
+     * @private
+     */
+    handleForgetClick_: function(index) {
+      var event = new CustomEvent('forgetpressed', {
+        bubbles: true,
+        detail: {
+          address: this.devices_.item(index).address,
+        }
+      });
+      this.dispatchEvent(event);
+    },
+
+    /**
      * Updates table row on change event of the device collection.
+     * @param {!Event} event
      * @private
-     * @param {!Event} event
      */
     handleChange_: function(event) {
       this.updateRow_(this.devices_.item(event.index), event.index);
     },
 
     /**
-     * Fires a inspect pressed event for the row |index|.
+     * Fires an inspect pressed event for the row |index|.
+     * @param {number} index
      * @private
-     * @param {number} index
      */
     handleInspectClick_: function(index) {
       var event = new CustomEvent('inspectpressed', {
         bubbles: true,
         detail: {
           address: this.devices_.item(index).address,
         }
       });
       this.dispatchEvent(event);
     },
 
     /**
      * Updates table row on splice event of the device collection.
+     * @param {!Event} event
      * @private
-     * @param {!Event} event
      */
     handleSplice_: function(event) {
       event.removed.forEach(function() {
         this.body_.deleteRow(event.index);
       }, this);
 
       event.added.forEach(function(device, index) {
         this.insertRow_(device, event.index + index);
       }, this);
     },
 
     /**
      * Inserts a new row at |index| and updates it with info from |device|.
-     * @private
      * @param {!interfaces.BluetoothDevice.DeviceInfo} device
      * @param {?number} index
+     * @private
      */
     insertRow_: function(device, index) {
       var row = this.body_.insertRow(index);
       row.id = device.address;
 
       for (var i = 0; i < this.headers_.length; i++) {
         row.insertCell();
       }
 
       // Make two extra cells for the inspect link and connect errors.
       var inspectCell = row.insertCell();
 
       var inspectLink = document.createElement('a', 'action-link');
+      inspectLink.textContent = 'Inspect';
       inspectCell.appendChild(inspectLink);
       inspectLink.addEventListener('click', function() {
         this.handleInspectClick_(row.sectionRowIndex);
       }.bind(this));
 
+      var forgetLink = document.createElement('a', 'action-link');
+      forgetLink.textContent = 'Forget';
+      inspectCell.appendChild(forgetLink);
+      forgetLink.addEventListener('click', function() {
+        this.handleForgetClick_(row.sectionRowIndex);
+      }.bind(this));
+
       this.updateRow_(device, row.sectionRowIndex);
     },
 
     /**
      * Deletes and recreates the table using the cached |devices_|.
      * @private
      */
     redraw_: function() {
       this.removeChild(this.body_);
       this.appendChild(document.createElement('tbody'));
       this.body_ = this.tBodies[0];
       this.body_.classList.add('table-body');
 
       for (var i = 0; i < this.devices_.length; i++) {
         this.insertRow_(this.devices_.item(i));
       }
     },
 
     /**
      * Updates the row at |index| with the info from |device|.
-     * @private
      * @param {!interfaces.BluetoothDevice.DeviceInfo} device
      * @param {number} index
+     * @private
      */
     updateRow_: function(device, index) {
       var row = this.body_.rows[index];
       assert(row, 'Row ' + index + ' is not in the table.');
 
       row.classList.toggle('removed', device.removed);
 
-      var inspectLink = row.cells[COLUMNS.INSPECT_LINK].children[0];
-      inspectLink.disabled = false;
-      switch (device.connectionStatus) {
-        case device_collection.ConnectionStatus.DISCONNECTED:
-          inspectLink.textContent = 'Inspect';
-          break;
-        case device_collection.ConnectionStatus.CONNECTED:
-          inspectLink.textContent = 'Forget';
-          break;
-        case device_collection.ConnectionStatus.CONNECTING:
-          inspectLink.disabled = true;
-          break;
-        default: assert('case not handled');
-      }
+      var forgetLink = row.cells[COLUMNS.LINKS].children[1];
+      forgetLink.disabled = !device.inspecting;
 
       // Update the properties based on the header field path.
       for (var i = 0; i < this.headers_.length; i++) {
         var header = this.headers_[i];
         var propName = header.dataset.field;
 
         var parts = propName.split('.');
         var obj = device;
         while (obj != null && parts.length > 0) {
           var part = parts.shift();
           obj = obj[part];
         }
 
         if (propName == 'is_gatt_connected') {
           obj = obj ? 'Connected' : 'Not Connected';
         }
 
         var cell = row.cells[i];
         cell.textContent = obj == null ? 'Unknown' : obj;
         cell.dataset.label = header.textContent;
       }
     },
   };
 
   return {
     DeviceTable: DeviceTable,
   };
 });