Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2576563002: [Mac] Reverse the omnibox in RTL (Closed)
Patch Set: Review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 08f552bd8484d646cf734a543c0de56b1a2ccaa7..378a7ebca69ba9e96a4542af8f648fb4e3ecb276 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -410,32 +410,32 @@ void LocationBarViewMac::OnDecorationsChanged() {
void LocationBarViewMac::Layout() {
AutocompleteTextFieldCell* cell = [field_ cell];
- // Reset the left-hand decorations.
+ // Reset the leading decorations.
// TODO(shess): Shortly, this code will live somewhere else, like in
// the constructor. I am still wrestling with how best to deal with
// right-hand decorations, which are not a static set.
[cell clearDecorations];
- [cell addLeftDecoration:location_icon_decoration_.get()];
- [cell addLeftDecoration:selected_keyword_decoration_.get()];
- [cell addLeftDecoration:security_state_bubble_decoration_.get()];
- [cell addRightDecoration:star_decoration_.get()];
- [cell addRightDecoration:translate_decoration_.get()];
- [cell addRightDecoration:zoom_decoration_.get()];
- [cell addRightDecoration:save_credit_card_decoration_.get()];
- [cell addRightDecoration:manage_passwords_decoration_.get()];
-
- // Note that display order is right to left.
+ [cell addLeadingDecoration:location_icon_decoration_.get()];
+ [cell addLeadingDecoration:selected_keyword_decoration_.get()];
+ [cell addLeadingDecoration:security_state_bubble_decoration_.get()];
+ [cell addTrailingDecoration:star_decoration_.get()];
+ [cell addTrailingDecoration:translate_decoration_.get()];
+ [cell addTrailingDecoration:zoom_decoration_.get()];
+ [cell addTrailingDecoration:save_credit_card_decoration_.get()];
+ [cell addTrailingDecoration:manage_passwords_decoration_.get()];
+
+ // Note that display order is front to back.
for (size_t i = 0; i < page_action_decorations_.size(); ++i) {
- [cell addRightDecoration:page_action_decorations_[i]];
+ [cell addTrailingDecoration:page_action_decorations_[i]];
}
for (ScopedVector<ContentSettingDecoration>::iterator i =
content_setting_decorations_.begin();
i != content_setting_decorations_.end(); ++i) {
- [cell addRightDecoration:*i];
+ [cell addTrailingDecoration:*i];
}
- [cell addRightDecoration:keyword_hint_decoration_.get()];
+ [cell addTrailingDecoration:keyword_hint_decoration_.get()];
// By default only the location icon is visible.
location_icon_decoration_->SetVisible(true);
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698